Details
- Reviewers
olasd - Group Reviewers
Reviewers - Commits
- rDSTOC8672a27146d9: Add test for skipped_content_missing.
rDSTO8672a27146d9: Add test for skipped_content_missing.
Diff Detail
- Repository
- rDSTO Storage manager
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/330/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/330/console
I don't really understand the rationale behind the test naming here, nor why the new test is skipped for the in-memory storage. Could you clarify?
swh/storage/tests/test_in_memory.py | ||
---|---|---|
32 | looks like for consistency this test should be renamed _db, not _pgsql |
The old test, that I renamed to _pgsql, does an SQL query. The new one is more portable.
nor why the new test is skipped for the in-memory storage. Could you clarify?
Because that endpoint is not implemented (T1633).
swh/storage/tests/test_in_memory.py | ||
---|---|---|
38 | Please reference the task here? |
Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/339/ for more details.
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/347/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/347/console
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/348/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/348/console