Page MenuHomeSoftware Heritage

Add test for skipped_content_missing.
ClosedPublic

Authored by vlorentz on Apr 9 2019, 4:28 PM.

Diff Detail

Repository
rDSTO Storage manager
Branch
test-skipped_content_missing
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5254
Build 7110: tox-on-jenkinsJenkins
Build 7109: arc lint + arc unit

Event Timeline

vlorentz created this revision.Apr 9 2019, 4:28 PM
olasd added a subscriber: olasd.Apr 9 2019, 5:00 PM

I don't really understand the rationale behind the test naming here, nor why the new test is skipped for the in-memory storage. Could you clarify?

swh/storage/tests/test_in_memory.py
32

looks like for consistency this test should be renamed _db, not _pgsql

In D1379#30012, @olasd wrote:

I don't really understand the rationale behind the test naming here

The old test, that I renamed to _pgsql, does an SQL query. The new one is more portable.

nor why the new test is skipped for the in-memory storage. Could you clarify?

Because that endpoint is not implemented (T1633).

vlorentz updated this revision to Diff 4446.Apr 9 2019, 5:14 PM
  • Fix crash
  • Rename test
olasd accepted this revision.Apr 9 2019, 5:25 PM
olasd added inline comments.
swh/storage/tests/test_in_memory.py
39

Please reference the task here?

This revision is now accepted and ready to land.Apr 9 2019, 5:25 PM
vlorentz updated this revision to Diff 4453.Apr 9 2019, 5:26 PM

reference the task.

This revision was landed with ongoing or failed builds.Apr 9 2019, 5:27 PM
This revision was automatically updated to reflect the committed changes.