Page MenuHomeSoftware Heritage
Differential D1354

Add support for replaying origin visits + more tests
ClosedPublic
Actions

Authored by vlorentz on Apr 5 2019, 2:53 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDJNL122399395945: Add support for replaying origin visits + more tests
Summary

Adds tests for writing+replaying releases, revisions, directories, origin_visits

Depends on D1351.

It uses attr to describe our data model, which hypothesis reads to build
objects.

Diff Detail

Repository
rDJNL Journal infrastructure
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Apr 5 2019, 2:53 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 5 2019, 2:53 PM
Harbormaster failed remote builds in B5133: Diff 4328!Apr 5 2019, 2:53 PM
swh-public-ci added a comment.Apr 5 2019, 2:53 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/103/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/103/console

vlorentz updated this revision to Diff 4339.Apr 5 2019, 4:53 PM
  • Add support for origin_visits
vlorentz retitled this revision from [WIP] Add tests for writing+replaying releases, revisions, and directories. to Add tests for writing+replaying releases, revisions, directories, origin_visits.Apr 5 2019, 4:54 PM
Harbormaster failed remote builds in B5142: Diff 4339!Apr 5 2019, 4:55 PM
swh-public-ci added a comment.Apr 5 2019, 4:55 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/106/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/106/console

vlorentz updated this revision to Diff 4342.Apr 5 2019, 5:08 PM
  • rebase
Harbormaster failed remote builds in B5145: Diff 4342!Apr 5 2019, 5:10 PM
swh-public-ci added a comment.Apr 5 2019, 5:10 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/109/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/109/console

vlorentz updated this revision to Diff 4344.Apr 5 2019, 5:28 PM
  • rebase
vlorentz retitled this revision from Add tests for writing+replaying releases, revisions, directories, origin_visits to Add support for replaying origin visits + more tests.Apr 5 2019, 5:28 PM
vlorentz edited the summary of this revision. (Show Details)
swh-public-ci added a comment.Apr 5 2019, 5:31 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/112/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/112/console

Harbormaster failed remote builds in B5147: Diff 4344!Apr 5 2019, 5:31 PM
vlorentz updated this revision to Diff 4357.Apr 5 2019, 7:36 PM
  • Use Hypothesis strategies from swh-model (D1360).
swh-public-ci added a comment.Apr 5 2019, 7:38 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/118/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/118/console

Harbormaster failed remote builds in B5160: Diff 4357!Apr 5 2019, 7:38 PM
ardumont added a subscriber: ardumont.Apr 6 2019, 11:14 AM
ardumont added inline comments.
swh/journal/tests/test_write_replay.py
67

GitDate

swh-public-ci added a comment.Apr 8 2019, 3:00 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/119/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/119/console

vlorentz updated this revision to Diff 4385.Apr 8 2019, 3:02 PM

Bump required swh-model version.

swh-public-ci added a comment.Apr 8 2019, 3:05 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/120/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/120/console

Harbormaster failed remote builds in B5191: Diff 4385!Apr 8 2019, 3:05 PM
olasd accepted this revision.Apr 8 2019, 3:51 PM
olasd added a subscriber: olasd.
olasd added inline comments.
swh/journal/replay.py
67

Please use logger.error('Foo %s', args): that way arguments have a chance to end up in the structured logging infrastructure, and we avoid interpolating when the log level isn't high enough to output the message.

This revision is now accepted and ready to land.Apr 8 2019, 3:51 PM
vlorentz updated this revision to Diff 4395.Apr 8 2019, 3:57 PM

Apply @olasd's comment.

swh-public-ci added a comment.Apr 8 2019, 4:01 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/125/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/125/console

Harbormaster failed remote builds in B5203: Diff 4395!Apr 8 2019, 4:01 PM
This revision was landed with ongoing or failed builds.Apr 8 2019, 8:23 PM
Closed by commit rDJNL122399395945: Add support for replaying origin visits + more tests (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
2 lines
swh/
journal/
17 lines
tests/
4 lines
62 lines

Diff 4396

View Options

requirements-test.txt

Loading...
View Options

swh/journal/replay.py

Loading...
View Options

swh/journal/tests/test_replay.py

Loading...
View Options

swh/journal/tests/test_write_replay.py

Loading...
About · Developer information · Legal