Page MenuHomeSoftware Heritage
Differential D1327

Make snapshot_add take an iterable of snapshot.
AbandonedPublic
Actions

Authored by vlorentz on Apr 1 2019, 4:12 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Summary

For uniformity with other _add() endpoints (except origin_visit_add).

Noone uses the new signature of snapshot_add except the tests yet,
so it's the perfect time to make this breaking change.

Diff Detail

Repository
rDSTO Storage manager
Branch
snapshot_add-many
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4992
Build 6692: tox-on-jenkinsJenkins
Build 6691: arc lint + arc unit

Event Timeline

vlorentz created this revision.Apr 1 2019, 4:12 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptApr 1 2019, 4:12 PM
Harbormaster failed remote builds in B4990: Diff 4226!Apr 1 2019, 4:12 PM
swh-public-ci added a comment.Apr 1 2019, 4:12 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/262/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/262/console

vlorentz added a parent revision: D1325: Use sha1 instead of bigint as FK from origin_visit to snapshot (part 2: backfill + start using the new colum for reading + cleanup).Apr 1 2019, 4:13 PM
swh-public-ci added a comment.Apr 1 2019, 4:13 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/264/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/264/console

vlorentz updated this revision to Diff 4227.Apr 1 2019, 4:16 PM

re-run jenkins build

Harbormaster failed remote builds in B4991: Diff 4227!Apr 1 2019, 4:16 PM
swh-public-ci added a comment.Apr 1 2019, 4:16 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/265/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/265/console

vlorentz updated this revision to Diff 4228.Apr 1 2019, 4:21 PM
  • add SQL migration
Harbormaster failed remote builds in B4992: Diff 4228!Apr 1 2019, 4:21 PM
swh-public-ci added a comment.Apr 1 2019, 4:21 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/266/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/266/console

vlorentz abandoned this revision.Apr 1 2019, 4:21 PM

Revision Contents
Changeset List

PathSize
sql/
upgrades/
46 lines
swh/
storage/
api/
10 lines
37 lines
sql/
1 line
54 lines
tests/
43 lines

Diff 4228

View Options

sql/upgrades/134.sql

Loading...
View Options

swh/storage/api/client.py

Loading...
View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/sql/40-swh-func.sql

Loading...
View Options

swh/storage/storage.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal