Paths

Table of Contentst

Differential D1309

test: Simplify kafka fixtures setup
ClosedPublic
Actions

Authored by ardumont on Mar 27 2019, 2:35 PM.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Commits

rDJNL7a0e11f264ee: test: Simplify kafka fixtures setup

Summary

Refactor the kafka consumer setup:

name it after what it does to be symmetric with producer_to_publisher
simplify its setup, dropping intermediary and unclear object request

Test Plan

tox

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Mar 27 2019, 2:35 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/68/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/68/console

Harbormaster failed remote builds in B4877: Diff 4125!Mar 27 2019, 2:36 PM

Don't forget to fix the flake8 warning before merging

This revision is now accepted and ready to land.Mar 27 2019, 2:46 PM

Fix pep8 violation

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/69/ for more details.

Harbormaster completed remote builds in B4879: Diff 4127.Mar 27 2019, 2:54 PM

In D1309#27919, @vlorentz wrote:

Don't forget to fix the flake8 warning before merging

Thanks, i:

missed a tox --recreate so flake8 was not working
my emacs' light theme does not show me the error (against my dark one which does)
apparently i no longer have the pre-commit hook refusing to commit when pep8 violation are present

Everything is fine! fine! fine.

Thanks for the heads up.

rebase

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/70/ for more details.

Harbormaster completed remote builds in B4881: Diff 4129.Mar 27 2019, 2:57 PM

Closed by commit rDJNL7a0e11f264ee: test: Simplify kafka fixtures setup (authored by ardumont). · Explain WhyMar 27 2019, 2:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

journal/

tests/

29 lines

test_publisher_kafka.py

9 lines

Diff 4130

swh/journal/tests/conftest.py

Loading...

swh/journal/tests/test_publisher_kafka.py

Loading...