Page MenuHomeSoftware Heritage

test: Simplify kafka fixtures setup
ClosedPublic

Authored by ardumont on Mar 27 2019, 2:35 PM.

Details

Summary

Refactor the kafka consumer setup:

  • name it after what it does to be symmetric with producer_to_publisher
  • simplify its setup, dropping intermediary and unclear object request
Test Plan

tox

Diff Detail

Repository
rDJNL Journal infrastructure
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4879
Build 6512: tox-on-jenkinsJenkins
Build 6511: arc lint + arc unit

Event Timeline

Don't forget to fix the flake8 warning before merging

This revision is now accepted and ready to land.Mar 27 2019, 2:46 PM

Don't forget to fix the flake8 warning before merging

Thanks, i:

  • missed a tox --recreate so flake8 was not working
  • my emacs' light theme does not show me the error (against my dark one which does)
  • apparently i no longer have the pre-commit hook refusing to commit when pep8 violation are present

Everything is fine! fine! fine.

Thanks for the heads up.

This revision was automatically updated to reflect the committed changes.