using an incremented counter, instead of pushing an inacurrate timing
data (if calling the encapsulated function raises an exception).
Depends on D1296
Details
Details
- Reviewers
olasd - Group Reviewers
Reviewers - Commits
- rDCOREae19bd9f88b0: statsd: make TimedContextManagerDecorator report errors
Diff Detail
Diff Detail
- Repository
- rDCORE Foundations and core functionalities
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/195/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/195/console
| swh/core/statsd.py | ||
|---|---|---|
| 100–106 | You can drop the start = None and replace finally:
if start is not None:
self._send(start)by: else:
self._send(start)(same comment for the block below) | |
| swh/core/statsd.py | ||
|---|---|---|
| 100–106 | gheez, you are damn right! | |
| swh/core/statsd.py | ||
|---|---|---|
| 100–106 | In fact no, at least not exactly, because of the return statement in the try block. | |
| swh/core/statsd.py | ||
|---|---|---|
| 100–106 | Oops indeed. The return could be at the end of the function, though. | |
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/197/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/197/console
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/198/ for more details.