Details
- Reviewers
olasd - Group Reviewers
Reviewers - Commits
- rDCIDX645f08ec432a: Add support for keywords in PKG-INFO.
Diff Detail
- Repository
- rDCIDX Metadata indexer
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/501/ for more details.
Wouldn't we want to deduplicate and sort the values?
Apart from that, the implementation looks sensible :-)
This function outputs JSON-LD arrays, which are unordered.
I don't think it's useful to deduplicate, as these keywords are written by a human, so duplicates would be intentional.
That's fair enough.
.oO(what's the point of an unordered array with duplicate values? :P)
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/503/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/503/console
I'm not sure that's the right judgment criterion here. A more pertinent one, AFAICT, is: does the resulting codemeta property wants/supports duplicate keyword or note? In translating we should make sure the result is consistent, no matter what were the properties of the original metadata provider.
They don't give any specific as to what it should look like. The only "specification" I can find is: "Keywords or tags used to describe this content. Multiple entries in a keywords list are typically delimited by commas." https://schema.org/keywords