Page MenuHomeSoftware Heritage
Differential D1178

swh.objstorage: Make the api use explicit configuration (+ checks)
ClosedPublic
Actions

Authored by ardumont on Feb 21 2019, 8:06 PM.

Details

Reviewers
douardda
vlorentz
Group Reviewers
Reviewers
Commits
rDOBJS0ecf2ed64ff9: api.server: Force unification on objstorage key setup
rDOBJS349309461b48: objstorage.api.server: Simplify configuration setup
rDOBJSf84e461d7e52: swh.objstorage: Make the api use explicit configuration (+ checks)
Summary
  • Open wsgi entrypoint for production use
  • Unify behavior with the vault (make_app, ...)
  • Bootstrap swh.objstorage cli
  • Checks the minimal configuration is ok and fail otherwise

Related T1533

Test Plan

tox

Diff Detail

Repository
rDOBJS Object storage
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4391
Build 5807: tox-on-jenkinsJenkins
Build 5806: arc lint + arc unit

Event Timeline

ardumont created this revision.Feb 21 2019, 8:06 PM
ardumont marked 2 inline comments as done.Feb 21 2019, 8:08 PM
ardumont added inline comments.
swh/objstorage/api/server.py
131

for retro-compatibility (tests uses flat configuration file, without the 'objstorage' top-level key)

150

This matches what is done in the vault.

ardumont added a child revision: D1179: swh-objstorage: Unify production and development start up.Feb 21 2019, 8:10 PM
ardumont added a child revision: D1180: objstorage: Use new wsgi entrypoint.Feb 21 2019, 8:16 PM
ardumont mentioned this in T1533: Make sure api server uses explicit configurations.Feb 21 2019, 8:34 PM
swh-public-ci added a subscriber: swh-public-ci.Feb 22 2019, 9:55 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DOBJS/job/tox/8/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJS/job/tox/8/console

Harbormaster failed remote builds in B4391: Diff 3706!Feb 22 2019, 9:55 AM
swh-public-ci added a comment.Feb 22 2019, 10:28 AM

Build is green
See https://jenkins.softwareheritage.org/job/DOBJS/job/tox/12/ for more details.

vlorentz accepted this revision.Feb 22 2019, 10:46 AM
vlorentz added inline comments.
swh/objstorage/api/server.py
131

Why don't you update the tests?

This revision is now accepted and ready to land.Feb 22 2019, 10:46 AM
ardumont updated this revision to Diff 3712.Feb 22 2019, 10:54 AM
  • objstorage.api.server: Simplify configuration setup
  • api.server: Force unification on objstorage key setup
ardumont marked an inline comment as done.Feb 22 2019, 10:55 AM
ardumont added inline comments.
swh/objstorage/api/server.py
131

tiredness/lazyness, choose ;)

I did it this morning.

Harbormaster completed remote builds in B4397: Diff 3712.Feb 22 2019, 10:56 AM
swh-public-ci added a comment.Feb 22 2019, 10:56 AM

Build is green
See https://jenkins.softwareheritage.org/job/DOBJS/job/tox/13/ for more details.

Closed by commit rDOBJSf84e461d7e52: swh.objstorage: Make the api use explicit configuration (+ checks) (authored by ardumont). · Explain WhyFeb 22 2019, 10:58 AM
This revision was automatically updated to reflect the committed changes.
ardumont mentioned this in rSPSITE58d896694038: objstorage: Fix configuration toplevel key.Feb 22 2019, 11:38 AM
ardumont mentioned this in rSPSITEfacfb4fd5aa0: objstorage: Fix configuration toplevel key.Feb 22 2019, 11:53 AM
ardumont mentioned this in rSPSITE331f7ebdbf75: objstorage: Fix configuration toplevel key.Feb 22 2019, 3:14 PM
ardumont mentioned this in D1182: swh.web.config: Allow configuration through environment variable.Feb 23 2019, 1:53 AM

Revision Contents
Changeset List

PathSize
4 lines
swh/
objstorage/
api/
159 lines
8 lines
27 lines
tests/
7 lines
134 lines

Diff 3706

View Options

setup.py

Loading...
View Options

swh/objstorage/api/server.py

Loading...
View Options

swh/objstorage/api/wsgi.py

Loading...
View Options

swh/objstorage/cli.py

Loading...
View Options

swh/objstorage/tests/test_objstorage_api.py

Loading...
View Options

swh/objstorage/tests/test_server.py

Loading...
About · Developer information · Legal