Differential D1133

Document the 'mappings' columns of revision_metadata and origin_intrinsic_metadata.
ClosedPublic
Actions

Authored by vlorentz on Feb 14 2019, 10:58 AM.

Details

Reviewers

zack

Group Reviewers

Reviewers

Commits

rDCIDXb43f534ec9e3: Document the 'mappings' columns of revision_metadata and…

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

mappings-doc

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 4224
Build 5571: tox-on-jenkins	Jenkins
Build 5570: arc lint + arc unit

Event Timeline

vlorentz created this revision.Feb 14 2019, 10:58 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 14 2019, 10:58 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/410/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/410/console

Harbormaster failed remote builds in B4224: Diff 3580!Feb 14 2019, 11:01 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/411/ for more details.

LGTM, thanks!

Speaking of which, it would be nice to have comments on all columns on all tables of all databases…

Fancy having a look at that or, alternatively, file a bug to track the need of doing so?

swh/indexer/sql/30-swh-schema.sql
17	not a blocker, but what happened to version 120?

This revision is now accepted and ready to land.Feb 14 2019, 11:07 AM

In D1133#24087, @zack wrote:

Speaking of which, it would be nice to have comments on all columns on all tables of all databases…

Fancy having a look at that or, alternatively, file a bug to track the need of doing so?

T1527

swh/indexer/sql/30-swh-schema.sql
17	I forgot to increment it here

rebase

Closed by commit rDCIDXb43f534ec9e3: Document the 'mappings' columns of revision_metadata and… (authored by vlorentz). · Explain WhyFeb 14 2019, 11:09 AM

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B4226: Diff 3582!Feb 14 2019, 11:10 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/412/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/412/console

ardumont mentioned this in T1527: Have comments on all columns of all databases.Jun 13 2019, 12:33 PM

Revision Contents
Changeset List

Path

Size

sql/

upgrades/

121.sql

10 lines

swh/

indexer/

sql/

30-swh-schema.sql

4 lines

Diff 3580

View Options

sql/upgrades/121.sql