Differential D1129

api/server: Do not read configuration at each request
ClosedPublic
Actions

Authored by ardumont on Feb 13 2019, 11:55 PM.

Tags

None

Subscribers

Details

Reviewers

douardda
vlorentz

Group Reviewers

Commits

rDSTOCa94451abefc8: api/server: Do not read configuration at each request
R65:a94451abefc8: api/server: Do not read configuration at each request
rDSTOa94451abefc8: api/server: Do not read configuration at each request

Summary

Same as D1128

Test Plan

tox

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Feb 13 2019, 11:55 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 13 2019, 11:55 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/195/ for more details.

Harbormaster completed remote builds in B4211: Diff 3566.Feb 13 2019, 11:59 PM

ardumont mentioned this in D1130: api/server: Do not read configuration at each request.Feb 14 2019, 12:02 AM

ardumont added reviewers: douardda, vlorentz.Feb 14 2019, 12:02 AM

ardumont marked an inline comment as done.Feb 14 2019, 12:04 AM

ardumont added inline comments.

swh/storage/api/server.py
394	Not sure if there is a way to actually extract this in swh.core. The default_config_path could possibly go away (to remove yet again the implicit configuration). The unsure stuff is about the global here. My mind tells me to go check closure and global but not right now ;)

douardda accepted this revision.Feb 14 2019, 9:43 AM

This revision is now accepted and ready to land.Feb 14 2019, 9:43 AM

Closed by commit rDSTOa94451abefc8: api/server: Do not read configuration at each request (authored by ardumont). · Explain WhyFeb 14 2019, 9:58 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

storage/

api/

9 lines

Diff 3576

swh/storage/api/server.py

Loading...