Page MenuHomeSoftware Heritage
Differential D1122

Use xmlschema instead of xmltodict for parsing pom.xml.
AbandonedPublic
Actions

Authored by vlorentz on Feb 12 2019, 6:53 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Summary

For now, validation is disabled, but it requires already many changes in
the code because it forces us to handles XML namespaces properly.

Note: this diff makes the translation 5 times longer to run.

Depends on D1121.

Diff Detail

Repository
rDCIDX Metadata indexer
Branch
pom-schema
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4186
Build 5521: tox-on-jenkinsJenkins
Build 5520: arc lint + arc unit

Event Timeline

vlorentz created this revision.Feb 12 2019, 6:53 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 12 2019, 6:53 PM
vlorentz updated this revision to Diff 3553.Feb 12 2019, 6:54 PM
vlorentz added a child revision: D1123: Use schema validation for pom.xml.
  • Fix base commit
swh-public-ci added a subscriber: swh-public-ci.Feb 12 2019, 6:55 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/398/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/398/console

Harbormaster failed remote builds in B4184: Diff 3551!Feb 12 2019, 6:56 PM
swh-public-ci added a comment.Feb 12 2019, 6:58 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/400/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/400/console

Harbormaster failed remote builds in B4186: Diff 3553!Feb 12 2019, 6:58 PM
vlorentz updated this revision to Diff 3556.Feb 12 2019, 7:03 PM
  • Rebase
Harbormaster failed remote builds in B4189: Diff 3556!Feb 12 2019, 7:03 PM
swh-public-ci added a comment.Feb 12 2019, 7:03 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/403/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/403/console

vlorentz edited the summary of this revision. (Show Details)Feb 13 2019, 3:22 PM
douardda requested changes to this revision.Feb 14 2019, 9:52 AM
douardda added a subscriber: douardda.
  • Commit missing stuff.
  • Fix commit again.
  • Fix requirements.txt
  • Add missing tests.

I don't buy it! Please use 'git rebase -i'!

This revision now requires changes to proceed.Feb 14 2019, 9:52 AM
vlorentz added a comment.Feb 14 2019, 10:44 AM
In D1122#24043, @douardda wrote:
  • Commit missing stuff.
  • Fix commit again.
  • Fix requirements.txt
  • Add missing tests.

I don't buy it! Please use 'git rebase -i'!

I use git rebase -i before merging, these commits will go away then.

vlorentz abandoned this revision.May 24 2019, 3:19 PM

Abandoning this diff, because it's overkill and slower, just to save a few lines of code.

Revision Contents
Changeset List

PathSize
swh/
indexer/
data/
maven/
1 line
202 lines
2484 lines
2 lines
151 lines
tests/
68 lines
36 lines

Diff 3553

View Options

swh/indexer/data/maven/CITATION

Loading...
View Options

swh/indexer/data/maven/LICENSE

Loading...
View Options

swh/indexer/data/maven/maven-4.0.0.xsd

Loading...
View Options

swh/indexer/exc.py

Loading...
View Options

swh/indexer/metadata_dictionary.py

Loading...
View Options

swh/indexer/tests/test_metadata.py

Loading...
View Options

swh/indexer/tests/utils.py

Loading...
About · Developer information · Legal