Page MenuHomeSoftware Heritage

Use xmlschema instead of xmltodict for parsing pom.xml.
Needs RevisionPublic

Authored by vlorentz on Feb 12 2019, 6:53 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Summary

For now, validation is disabled, but it requires already many changes in
the code because it forces us to handles XML namespaces properly.

Note: this diff makes the translation 5 times longer to run.

Depends on D1121.

Diff Detail

Repository
rDCIDX Object indexer
Branch
pom-schema
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4189
Build 5527: tox-on-jenkinsJenkins
Build 5526: arc lint + arc unit

Event Timeline

vlorentz created this revision.Feb 12 2019, 6:53 PM
vlorentz updated this revision to Diff 3553.Feb 12 2019, 6:54 PM
  • Fix base commit
vlorentz updated this revision to Diff 3556.Feb 12 2019, 7:03 PM
  • Rebase
vlorentz edited the summary of this revision. (Show Details)Feb 13 2019, 3:22 PM
douardda requested changes to this revision.Feb 14 2019, 9:52 AM
douardda added a subscriber: douardda.
  • Commit missing stuff.
  • Fix commit again.
  • Fix requirements.txt
  • Add missing tests.

I don't buy it! Please use 'git rebase -i'!

This revision now requires changes to proceed.Feb 14 2019, 9:52 AM
  • Commit missing stuff.
  • Fix commit again.
  • Fix requirements.txt
  • Add missing tests.

    I don't buy it! Please use 'git rebase -i'!

I use git rebase -i before merging, these commits will go away then.