Page MenuHomeSoftware Heritage

gbp-buildpackage: Open pgdg as a new extra debian repository
ClosedPublic

Authored by ardumont on Feb 11 2019, 1:47 PM.

Details

Summary

And update swh-scheduler's build job which needs that extra repository
(stable only)

Test Plan

Build scheduler job with this and the stable build should be good
(once the hypothesis version requirements is bumped as well).

Diff Detail

Repository
rCJSWH Jenkins jobs
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4137
Build 5449: arc lint + arc unit

Event Timeline

ardumont added inline comments.
jobs/templates/debian/gbp-buildpackage.groovy
115

I initially found another public key [1] at [2].
Then checking the dockerfile for jenkins, i found this [3]

To stay consistent, i used [3] (but they are the same anyway [4])

[1] http://apt.postgresql.org/pub/repos/apt/ACCC4CF8.asc

[2] https://www.postgresql.org/about/news/1432/

[3] https://forge.softwareheritage.org/source/swh-jenkins-dockerfiles/browse/master/base/Dockerfile$11

[4] Same public key anyway

$ wget -q http://apt.postgresql.org/pub/repos/apt/ACCC4CF8.asc
$ sha1sum ACCC4CF8.asc
403374e8f22266f67fe14b79b8257491dce75af7  ACCC4CF8.asc
$ wget -q -O ACCC4CF8.2.asc https://www.postgresql.org/media/keys/ACCC4CF8.asc
$ sha1sum ACCC4CF8.2.asc
403374e8f22266f67fe14b79b8257491dce75af7  ACCC4CF8.2.asc
ardumont added inline comments.
jobs/templates/debian/gbp-buildpackage.yaml
35

badly formulated, i'm changing this.

Rework description of the new repository pgdg

ardumont added inline comments.
jobs/templates/debian/gbp-buildpackage.yaml
35

done

jobs/templates/debian/gbp-buildpackage.groovy
115

;; is wrong here, should be //

  • gbp-buildpackage: Fix comment syntax
This revision is now accepted and ready to land.Feb 12 2019, 9:23 AM
ardumont marked an inline comment as done.

Rebase

This revision was automatically updated to reflect the committed changes.