Page MenuHomeSoftware Heritage
Differential D1091

Make the OriginMetadataIndexer call storage.revision_get a single time for all revisions.
ClosedPublic
Actions

Authored by vlorentz on Feb 6 2019, 4:57 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Commits
rDCIDX50497465bd1d: Make the OriginMetadataIndexer call storage.revision_get a single time for all…
Summary

Depends on D1090

Diff Detail

Repository
rDCIDX Metadata indexer
Branch
OriginMetadataIndexer-revision_get-single-query
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4048
Build 5316: tox-on-jenkinsJenkins
Build 5315: arc lint + arc unit

Event Timeline

vlorentz created this revision.Feb 6 2019, 4:57 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 6 2019, 4:57 PM
Harbormaster failed remote builds in B4048: Diff 3420!Feb 6 2019, 4:57 PM
swh-public-ci added a subscriber: swh-public-ci.Feb 6 2019, 4:57 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/322/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/322/console

vlorentz removed a parent revision: D1088: Make Storage.origin_get support a list of origins, like other Storage.*_get methods..Feb 6 2019, 4:57 PM
vlorentz edited the summary of this revision. (Show Details)
douardda requested changes to this revision.Feb 7 2019, 10:02 AM
douardda added a subscriber: douardda.

Could you please explain in the commit message why you do this diff? Also the 'assert False' looks really strange. What is its practical purpose?

This revision now requires changes to proceed.Feb 7 2019, 10:02 AM
vlorentz updated this revision to Diff 3430.Feb 7 2019, 12:31 PM
  • Make Indexer.index a non-abstract method.
Harbormaster failed remote builds in B4057: Diff 3430!Feb 7 2019, 12:31 PM
swh-public-ci added a comment.Feb 7 2019, 12:31 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/354/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/354/console

vlorentz added a comment.Feb 7 2019, 12:31 PM
In D1091#23082, @douardda wrote:

Could you please explain in the commit message why you do this diff? Also the 'assert False' looks really strange. What is its practical purpose?

That was because index was an abstract method of the parent class. Fixed.

douardda accepted this revision.Feb 8 2019, 10:42 AM
This revision is now accepted and ready to land.Feb 8 2019, 10:42 AM
vlorentz updated this revision to Diff 3483.Feb 8 2019, 12:14 PM
  • rebase
  • reword commit
Closed by commit rDCIDX50497465bd1d: Make the OriginMetadataIndexer call storage.revision_get a single time for all… (authored by vlorentz). · Explain WhyFeb 8 2019, 12:15 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B4110: Diff 3483!Feb 8 2019, 12:15 PM
swh-public-ci added a comment.Feb 8 2019, 12:15 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/377/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/377/console

Revision Contents
Changeset List

PathSize
swh/
indexer/
55 lines

Diff 3420

View Options

swh/indexer/metadata.py

Loading...
About · Developer information · Legal