Page MenuHomeSoftware Heritage

Make the OriginMetadataIndexer call storage.revision_get a single time for all revisions.
ClosedPublic

Authored by vlorentz on Wed, Feb 6, 4:57 PM.

Diff Detail

Repository
rDCIDX Object indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Wed, Feb 6, 4:57 PM
douardda requested changes to this revision.Thu, Feb 7, 10:02 AM
douardda added a subscriber: douardda.

Could you please explain in the commit message why you do this diff? Also the 'assert False' looks really strange. What is its practical purpose?

This revision now requires changes to proceed.Thu, Feb 7, 10:02 AM
vlorentz updated this revision to Diff 3430.Thu, Feb 7, 12:31 PM
  • Make Indexer.index a non-abstract method.

Could you please explain in the commit message why you do this diff? Also the 'assert False' looks really strange. What is its practical purpose?

That was because index was an abstract method of the parent class. Fixed.

douardda accepted this revision.Fri, Feb 8, 10:42 AM
This revision is now accepted and ready to land.Fri, Feb 8, 10:42 AM
vlorentz updated this revision to Diff 3483.Fri, Feb 8, 12:14 PM
  • rebase
  • reword commit
This revision was automatically updated to reflect the committed changes.