So subclasses can override them if needed.
Details
- Reviewers
douardda - Group Reviewers
Reviewers - Commits
- rDCIDXc7e20d9567db: Split OriginIndexer.run into smaller methods.
Diff Detail
- Repository
- rDCIDX Metadata indexer
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/320/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/320/console
Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/321/ for more details.
One drawback of this function extraction is that you now have to keep an intermediate result (the origins list). Couldn't this be avoided using generators?
swh/indexer/indexer.py | ||
---|---|---|
554 | self not being used in the body of the method, make it either a simple function or a static method. Also extracting a piece of code like this in a dedicated function make it easier to test it. Just sayin'! |
That's a very small list (I'd be surprised if it ever gets over 10KB). And starting with D1092, we'll download the whole list at once anyway.
Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/328/ for more details.
Well, you do not know that for sure, the list is an input for this method. And to state the obvious, oceans are made of small drops ;-)
Whatever, it's probably not a deal, indeed, so let's keep moving...
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/372/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/372/console