Paths

Table of Contentst

Differential D1080

Restructure origin_metadata_indexer_test to make it easier to add more origin metadata idx tests.
AbandonedPublic
Actions

Authored by vlorentz on Feb 5 2019, 12:02 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

origin-metadata-test

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 4013
Build 5264: tox-on-jenkins	Jenkins
Build 5263: arc lint + arc unit

Event Timeline

vlorentz created this revision.Feb 5 2019, 12:02 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 5 2019, 12:02 PM

vlorentz added a child revision: D1081: Prevent OriginMetadataIndexer from sending duplicate revisions to revision_metadata_add..Feb 5 2019, 12:04 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/316/ for more details.

Harbormaster completed remote builds in B4013: Diff 3393.Feb 5 2019, 12:06 PM

Why not make this decorator a pytest fixture?

ask rework just for the sake of the fixture question

This revision now requires changes to proceed.Feb 7 2019, 10:19 AM

How would you do it?

(Actually, after thinking more about this, a class with setUp and tearDown looks like better than my decorator solution.)

In D1080#23137, @vlorentz wrote:

(Actually, after thinking more about this, a class with setUp and tearDown looks like better than my decorator solution.)

nope, just write a pytest fixture!

https://docs.pytest.org/en/latest/fixture.html

In D1080#23298, @douardda wrote:
In D1080#23137, @vlorentz wrote:

(Actually, after thinking more about this, a class with setUp and tearDown looks like better than my decorator solution.)

nope, just write a pytest fixture!
https://docs.pytest.org/en/latest/fixture.html

I know, that was just another idea.

I was asking how you would structure this into fixtures. But I figured it out while phrasing this message :)

vlorentz mentioned this in D1106: Move boilerplate out of test_origin_metadata_indexer so it's reusable by other tests..Feb 8 2019, 11:55 AM

Replaced by D1106.

vlorentz removed a child revision: D1081: Prevent OriginMetadataIndexer from sending duplicate revisions to revision_metadata_add..Feb 8 2019, 11:58 AM

vlorentz added a child revision: D1081: Prevent OriginMetadataIndexer from sending duplicate revisions to revision_metadata_add..Feb 8 2019, 12:02 PM

Revision Contents
Changeset List

Path

Size

swh/

indexer/

tests/

test_origin_metadata.py

123 lines

Diff 3393

swh/indexer/tests/test_origin_metadata.py

Loading...