Page MenuHomeSoftware Heritage

Restructure origin_metadata_indexer_test to make it easier to add more origin metadata idx tests.
AbandonedPublic

Authored by vlorentz on Feb 5 2019, 12:02 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers

Diff Detail

Repository
rDCIDX Object indexer
Branch
origin-metadata-test
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 4013
Build 5264: tox-on-jenkinsJenkins
Build 5263: arc lint + arc unit

Event Timeline

vlorentz created this revision.Feb 5 2019, 12:02 PM

Why not make this decorator a pytest fixture?

douardda requested changes to this revision.Feb 7 2019, 10:19 AM

ask rework just for the sake of the fixture question

This revision now requires changes to proceed.Feb 7 2019, 10:19 AM

How would you do it?

(Actually, after thinking more about this, a class with setUp and tearDown looks like better than my decorator solution.)

(Actually, after thinking more about this, a class with setUp and tearDown looks like better than my decorator solution.)

nope, just write a pytest fixture!

https://docs.pytest.org/en/latest/fixture.html

(Actually, after thinking more about this, a class with setUp and tearDown looks like better than my decorator solution.)

nope, just write a pytest fixture!

https://docs.pytest.org/en/latest/fixture.html

I know, that was just another idea.

I was asking how you would structure this into fixtures. But I figured it out while phrasing this message :)

vlorentz abandoned this revision.Feb 8 2019, 11:56 AM

Replaced by D1106.