Differential D108

Http API to access the SWH vault
ClosedPublic
Actions

Authored by qcampos on Aug 24 2016, 1:01 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T532: Vault API

Commits

rDSTOCa71109b66538: Http API to access the SWH vault
R65:a71109b66538: Http API to access the SWH vault
rDVAU1ff7d2a8a5fd: Http API to access the SWH vault
rDSTOa71109b66538: Http API to access the SWH vault

Summary

This API currently only concern the directories as it uses the first draft of the cooker.

Ref T532
Depends on D102

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

qcampos updated this revision to Diff 366.Aug 24 2016, 1:01 PM

qcampos retitled this revision from to Http API to access the SWH vault.

qcampos updated this object.

qcampos edited the test plan for this revision. (Show Details)

qcampos added a task: T532: Vault API.

qcampos added a parent revision: D102: First version of the directory cooker & cache.

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 24 2016, 1:01 PM

If you have the time to do the small refactoring about the api redundancy, please do it.

Otherwise, this seems good to go so accepted.

swh/storage/vault/api/client.py
61	I see those same (or equivalent) snippets in swh.storage.api.client.RemoteStorage, swh.objstorage.api.client.RemoteObjStorage. Can't we factorize those methods (url, post, get seems new) say in a base class somewhere? swh.objstorage seems appropriate for this since swh-storage already depends on it.
swh/storage/vault/api/server.py
64	Maybe explicit that this is to be called when the directory is cooked. By updating the function name for example, get_cooked_directory.

This revision is now accepted and ready to land.Aug 29 2016, 1:07 PM

Rename method to make it more explicit

get_directory was misleading as in only concern cooked directory.
As the endpoint is already GET/POST-specific, this enlightment is needed.

This revision now requires review to proceed.Sep 12 2016, 11:47 AM

ardumont accepted this revision.Sep 12 2016, 11:56 AM

ardumont edited edge metadata.

ardumont added inline comments.

swh/storage/vault/api/cooking_tasks.py
18	ah yes, nice catch, bytes won't pass with celery without adding some extra converters ^^

This revision is now accepted and ready to land.Sep 12 2016, 11:56 AM

Closed by commit rDSTOa71109b66538: Http API to access the SWH vault (authored by qcampos). · Explain WhySep 12 2016, 2:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

storage/

vault/

api/

71 lines

cooking_tasks.py

24 lines

92 lines

Diff 402

swh/storage/vault/api/client.py

Loading...

swh/storage/vault/api/cooking_tasks.py

Loading...

swh/storage/vault/api/server.py

Loading...