HomeSoftware Heritage

d/control; d/rules: Test the package

Description

d/control; d/rules: Test the package

Details

Provenance
olasdAuthored on Jun 14 2016, 5:34 PM
olasdPushed on Jul 19 2016, 11:13 AM
Parents
rDWAPPS32964ddac25e: utils: parse_datetime always returns a tz aware datetime
Branches
Unknown
Tags
Unknown

Event Timeline

ardumont added inline comments.
/debian/control
26

@olasd Sorry to make you repeat but i don't get it.
Why is it necessary to add it here?

What i understood so far is that the runtime dependencies (keyword Depends for Debian's control file) are supposed to be taken care of by the /setup.py and /requirements.txt couple on each repository.
But somehow, you said to me a while back, it is not working properly (which I interpreted as not exhaustive).

My biggest misunderstanding is why don't we copy all the runtime dependencies, say for example here libjs-jquery-flot, libjs-jquery-flot-tooltip, python3-flask-api?

Thanks for your enlightenment.

/debian/control
26

The python packaging toolchain generates *python* dependencies from requirements.txt.

However, it doesn't propagate *version constraints* to the runtime dependencies, as they are often wrong (lots of upstreams hardcode versions to what they have tested, and only those they have tested, making packaging for distributions annoying).

Adding versioned dependencies is necessary to make upgrades work properly. In that specific case, I think the versions were added a while back, then removed, and got readded when I rebased this commit on top of most recent ones.

The runtime dependencies on javascript libraries are indeed missing. python3-flask-api is added by ${python3:Depends} as it exists in requirements.txt.

/debian/control
26

The python packaging toolchain generates *python* dependencies from requirements.txt.

That's what i was missing, only python's.

... then removed, ...

I may be one who did that in my misunderstanding ^^.
So thanks for fixing it.

The runtime dependencies on javascript libraries are indeed missing.

Ok.

So, here, we either need to add runtime dependencies:

  • any non python3 package with their version constraints (if any)
  • or python3 related package if the constraints are needed (for example our python3-swh* modules)

python3-flask-api is added by ${python3:Depends} as it exists in requirements.txt.

Ok.

Thanks for clarifying ^^