HomeSoftware Heritage

package loaders: define extid types
Concern Raisede9a8f986809c

Description

package loaders: define extid types

This is still a purely internal change for now, but it will be needed
to read/write ExtIDs from/to the storage.

Details

Auditors
olasd
Provenance
vlorentzAuthored on Mar 23 2021, 3:58 PM
vlorentzPushed on Mar 23 2021, 4:33 PM
Parents
rDLDBASEeef74bbfacc0: Deduplicate resolve_revision_from across package loaders
Branches
Unknown
Tags
Unknown
Build Status
Buildable 20129
Build 31255: test-and-buildJenkins console · Jenkins

Event Timeline

olasd raised a concern with this commit.Mar 23 2021, 6:09 PM
olasd added a subscriber: olasd.
olasd added inline comments.
/swh/loader/package/npm/loader.py
41

Probably needs a mention of npm (in that another loader may interpret an identical source archive differently?)

/swh/loader/package/pypi/loader.py
37

Same as npm, this probably needs to mention pypi.

This commit now has outstanding concerns.Mar 23 2021, 6:09 PM

Indeed. I discarded this idea, but can't remember why...