HomeSoftware Heritage

Make tests pass with django 2

Authored by douardda on Jan 10 2020, 3:43 PM.


Make tests pass with django 2

For this we:

  • ensure we create the DepositRequest with str as raw_metadata (instead of a bytes), and
  • make atom_dataset return a str instead of a bytes

    Every time this chunk of data is sent on the wire (http req to the django app) this needs to be an str, otherwise we have things like:

    raw_metadata = "b'[...]'"

    especially when testing against django 2, which is the only django version available on debian sid, so this is needed to make it possible to build the deb file on sid *with* tests enabled.
  • add a py3-django2 environment in tox
  • bump the dependency to django <3 in requirements-server.txt (otherwise it will take precendence on the deps: field of the tox file, thus execute tests in py3-django2 with django 1.11).

Note that no other tests than executing pytest have been done with django2, so
do not expect it works flawlessly.


douarddaJan 10 2020, 4:59 PM
douarddaJan 13 2020, 11:21 AM
Differential Revision
D2517: Add tox.ini and pytest.ini in the file
rDDEP00eadef47217: Add tox.ini and pytest.ini in the file
Build Status
Buildable 10046
Build 14871: test-and-buildJenkins