In T782#20044, @zack wrote:

So, good news at last! The CLA is ready, here it is: L3 . (It misses a preamble, but it's pretty short anyway without one.)
@s : Can you have a look and sign it (using your legal name) ?
Happy to answer any question you might have !

"zack (Stefano Zacchiroli)" <forge@softwareheritage.org> writes:

@ardumont, Can I:

In D302#6173, @ardumont wrote:

Tested locally and all fine. Nice job!

In D301#6174, @ardumont wrote:

Tested locally and all fine. Nice job!

In D302#6155, @ardumont wrote:

Oh, also, i believe the tests need some love:
...

In D301#6156, @ardumont wrote:

Remains to adapt the tests accordingly ;)

...

• swh: Fix test for db_to_fossology_license.
• swh: Fix tests in CommonTestStorage.

• swh.web.tests.common.test_service: Fix tests in ServiceTestCase

In D302#6155, @ardumont wrote:

Oh, also, i believe the tests need some love:

make test

should give you some hints ;)

In D302#6153, @ardumont wrote:

Sounds good.

One minor nitpick in the description

Now, lookup_content_license function returns a dictionary with the following keys

Now reading this comment and the code could be confusing (we say it's a dict but the code extract data from list ;)
So clarifying, D301 introduces a dict generator (well, depending on the deployed configuration).
As you mentioned, each dict holds 1 key sha1 and 1 value which are facts, list of {tool + associated detected license for that tool on the sha1}

Change structure of yield value for content_fossology_license_get

Setup

If the changes look good, I'll update the failing tests and submit a patch for code review.

I'd be more than ok if you could open a diff now with arcanist?
(Even if tests are not completely ok yet ;)

@ardumont, Thanks for the data dumps (F3040109 and F3040114). I'm able [[ https://ricketyspace.net/tmp/t782-swh-indexer-changes.webm | to test the /api/1/content/sha1:HASH/license/ endpoint ]].

@ardumont Thank you very much for helping out.

@zack, I've been getting myself acquainted with the swh codebase for the past few days.

@zack, I would like to work on this issue.