Page MenuHomeSoftware Heritage
Differential D2728

Add /ping/ endpoint to Web API
ClosedPublic
Actions

Authored by krithikvaidya on Feb 28 2020, 1:22 PM.

Details

Reviewers
anlambert
Maniphest Tasks
T2294: Web API: add a /ping endpoint
Commits
rDWAPPSf77207f42eb0: Add /ping/ endpoint to Web API
Summary

Adds a /ping/ endpoint to SWH Web API that simply returns "pong"

References T2294

Diff Detail

Event Timeline

krithikvaidya created this revision.Feb 28 2020, 1:22 PM
swh-public-ci added a comment.Feb 28 2020, 1:30 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/983/ for more details.

swh-public-ci added a comment.Feb 28 2020, 1:32 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/592/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/592/console

Harbormaster failed remote builds in B10798: Diff 9731!Feb 28 2020, 1:32 PM
krithikvaidya edited the summary of this revision. (Show Details)Feb 28 2020, 1:44 PM
krithikvaidya added a task: T2294: Web API: add a /ping endpoint.
krithikvaidya added a comment.Feb 28 2020, 1:48 PM

Not sure why the Cypress tests are failing...

anlambert added a comment.Feb 28 2020, 1:57 PM
In D2728#65170, @krithikvaidya wrote:

Not sure why the Cypress tests are failing...

This is not related to your changes. I will fix the issue and the tests should pass again once your diff rebased on master.

anlambert requested changes to this revision.Feb 28 2020, 2:00 PM

Looks good but you need to add a test to validate the changes. You can inspire from that test implementation.

swh/web/api/views/ping.py
16

s/test/endpoint/

20–24

You can remove these lines.

This revision now requires changes to proceed.Feb 28 2020, 2:00 PM
krithikvaidya updated this revision to Diff 9743.Feb 28 2020, 3:02 PM

Add test for ping endpoint

krithikvaidya marked an inline comment as done.Feb 28 2020, 3:03 PM
swh-public-ci added a comment.Feb 28 2020, 3:11 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/984/ for more details.

swh-public-ci added a comment.Feb 28 2020, 3:13 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/593/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/593/console

Harbormaster failed remote builds in B10809: Diff 9743!Feb 28 2020, 3:13 PM
anlambert requested changes to this revision.Feb 28 2020, 4:39 PM

All good ! Before I accept the diff, please rebase it to origin/master, squash the commits and update the commit log as follow:

Add /ping/ endpoint to Web API

Closes T2294
This revision now requires changes to proceed.Feb 28 2020, 4:39 PM
krithikvaidya updated this revision to Diff 9756.EditedFeb 28 2020, 6:20 PM

Squashed commits, rebase branch on origin/master

All done, will merge with master on approval. Thanks for the review 😄

swh-public-ci added a comment.Feb 28 2020, 6:22 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/986/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/986/console

Harbormaster failed remote builds in B10816: Diff 9756!Feb 28 2020, 6:22 PM
swh-public-ci added a comment.Feb 28 2020, 6:25 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/595/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/595/console

anlambert requested changes to this revision.Mar 2 2020, 3:04 PM

@krithikvaidya, please rebase the diff once again on origin/master, this will fix the CI builds.

Also I forgot to tell you to add yourself in the CONTRIBUTORS file at the root of the repository.

Once it is done, I will accept the diff.

This revision now requires changes to proceed.Mar 2 2020, 3:04 PM
krithikvaidya updated this revision to Diff 9790.Mar 2 2020, 6:37 PM

Rebased branch on origin/master, added name to CONTRIBUTORS

swh-public-ci added a comment.Mar 2 2020, 6:40 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/988/ for more details.

swh-public-ci added a comment.Mar 2 2020, 6:47 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/597/ for more details.

Harbormaster completed remote builds in B10847: Diff 9790.Mar 2 2020, 6:47 PM
anlambert removed a reviewer: zack.Mar 2 2020, 6:48 PM
anlambert accepted this revision.Mar 2 2020, 6:50 PM

Thanks for your work on this. You can now merge your feature branch to your local master branch and push it to origin/master.

This revision is now accepted and ready to land.Mar 2 2020, 6:50 PM
Closed by commit rDWAPPSf77207f42eb0: Add /ping/ endpoint to Web API (authored by krithikvaidya). · Explain WhyMar 2 2020, 6:52 PM
This revision was automatically updated to reflect the committed changes.
krithikvaidya added a commit: rDWAPPSf77207f42eb0: Add /ping/ endpoint to Web API.
krithikvaidya added a comment.Mar 2 2020, 6:53 PM

yep, done :)

Revision Contents
Changeset List

PathSize
swh/
web/
api/
3 lines
views/
27 lines

Diff 9731

View Options

swh/web/api/urls.py

Loading...
View Options

swh/web/api/views/ping.py

Loading...
About · Developer information · Legal