Paths

Table of Contentst

Differential D2629

dataset: add graph export based on kafka
AbandonedPublic
Actions

Authored by seirl on Feb 5 2020, 7:02 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Diff Detail

Repository

rDDATASET Datasets

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 10460
Build 15584: arc lint + arc unit

Event Timeline

seirl created this revision.Feb 5 2020, 7:02 PM

Harbormaster completed remote builds in B10459: Diff 9398.Feb 5 2020, 7:02 PM

Remove commented out part

Harbormaster completed remote builds in B10460: Diff 9399.Feb 5 2020, 7:04 PM

Remove useless while true

Harbormaster completed remote builds in B10461: Diff 9400.Feb 5 2020, 7:08 PM

zack added a reviewer: Reviewers.Feb 5 2020, 7:53 PM

Missing tests?

swh/dataset/cli.py
1	headers date range ;)
18	`,),` you can drop one comma.
34	docstring so click has something relevant to display when called with no or wrong arguments.
44	You might want that to be a default list so you could parametrize the call from cli.
swh/dataset/graph.py
7	hashutil before identifiers
10	docstrings?

seirl planned changes to this revision.Feb 11 2020, 5:40 PM

seirl added inline comments.

swh/dataset/cli.py
44	I don't think we want to do that, it would have other weird implications.

Obsoleted by D3011

Revision Contents
Changeset List

Path

Size

swh/

dataset/

55 lines

34 lines

Diff 9399

swh/dataset/cli.py

Loading...

swh/dataset/graph.py

Loading...