Paths

Table of Contentst

Differential D2423

Add sentry integration to swh-web
ClosedPublic
Actions

Authored by vlorentz on Dec 10 2019, 2:06 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T1359: Add sentry support in every swh running service

Commits

rDWAPPSeb8f0e52db96: Add sentry integration.

Diff Detail

Repository

rDWAPPS Web applications

Branch

sentry

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 9650
Build 14220: Cypress tests for swh-web diffs	Jenkins
Build 14219: tox-on-jenkins	Jenkins
Build 14218: arc lint + arc unit

Event Timeline

vlorentz created this revision.Dec 10 2019, 2:06 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 10 2019, 2:06 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/839/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/839/console

Harbormaster failed remote builds in B9646: Diff 8567!Dec 10 2019, 2:08 PM

vlorentz added inline comments.Dec 10 2019, 2:09 PM

swh/web/browse/views/revision.py
285	note that I changed this to be stricted. But this block is wrapped in a larger `except Exception as exc:`, which will catch other exceptions, if any.
swh/web/common/throttling.py
70–106	I did some refactoring here to capture only `ImproperlyConfigured` instead of all exceptions; and also to make the `try` block as short as possible to not catch too many errors.

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/840/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/840/console

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/437/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/437/console

Work around pip's lack of a dependency resolver
Silence mypy about override of post_fork

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/841/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/438/ for more details.

Harbormaster completed remote builds in B9648: Diff 8569.Dec 10 2019, 2:37 PM

add tests for gunicorn_config.

anlambert added a subscriber: anlambert.Dec 10 2019, 2:44 PM

anlambert added inline comments.

swh/web/settings/gunicorn_config.py
1	The `swh/web/settings` folder is dedicated to contain Django configuration. I think that file should be moved in the `swh/web` directory which already contains configuration related modules.

move as requested.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/842/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/843/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/439/ for more details.

Harbormaster completed remote builds in B9650: Diff 8571.Dec 10 2019, 2:56 PM

Looks good to me !

This revision is now accepted and ready to land.Dec 10 2019, 2:57 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/440/ for more details.

Harbormaster completed remote builds in B9651: Diff 8572.Dec 10 2019, 3:10 PM

rebase

This revision was landed with ongoing or failed builds.Dec 10 2019, 5:58 PM

Closed by commit rDWAPPSeb8f0e52db96: Add sentry integration. (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDWAPPSeb8f0e52db96: Add sentry integration..

Harbormaster failed remote builds in B9664: Diff 8583!Dec 10 2019, 5:58 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/441/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/441/console

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/844/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/844/console

vlorentz added a task: T1359: Add sentry support in every swh running service .Dec 11 2019, 3:41 PM

Revision Contents
Changeset List

Path

Size

requirements-swh.txt

1 line

requirements-test.txt

3 lines

requirements.txt

1 line

swh/

web/

admin/

4 lines

api/

4 lines

browse/

17 lines

views/

8 lines

7 lines

11 lines

2 lines

utils/

snapshot_context.py

7 lines

common/

2 lines

6 lines

5 lines

20 lines

swh_templatetags.py

8 lines

32 lines

5 lines

misc/

5 lines

settings/

gunicorn_config.py

14 lines

tests/

test_gunicorn_config.py

51 lines

Diff 8571

requirements-swh.txt

Loading...

requirements-test.txt

Loading...

requirements.txt

Loading...

swh/web/admin/deposit.py

Loading...

swh/web/api/apidoc.py

Loading...

swh/web/browse/utils.py

Loading...

swh/web/browse/views/content.py

Loading...

swh/web/browse/views/directory.py

Loading...

swh/web/browse/views/release.py

Loading...

swh/web/browse/views/revision.py

Loading...

swh/web/browse/views/utils/snapshot_context.py

Loading...

swh/web/common/exc.py

Loading...

swh/web/common/highlightjs.py

Loading...

swh/web/common/middlewares.py

Loading...

swh/web/common/origin_save.py

Loading...

swh/web/common/swh_templatetags.py

Loading...

swh/web/common/throttling.py

Loading...

swh/web/doc_config.py

Loading...

swh/web/misc/urls.py

Loading...

swh/web/settings/gunicorn_config.py

Loading...

swh/web/tests/test_gunicorn_config.py

Loading...