Page MenuHomeSoftware Heritage
Differential D2364

Remove 'internal' endpoint browse-origin-search.
ClosedPublic
Actions

Authored by vlorentz on Nov 27 2019, 3:47 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDWAPPS921236dae1e9: Remove 'internal' endpoint browse-origin-search.
Summary

The API does the same job.

Depends on D2363.

Diff Detail

Repository
rDWAPPS Web applications
Branch
rm-browse-origin-search
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9399
Build 13772: Cypress tests for swh-web diffsJenkins
Build 13771: tox-on-jenkinsJenkins
Build 13770: arc lint + arc unit

Event Timeline

vlorentz created this revision.Nov 27 2019, 3:47 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 27 2019, 3:47 PM
swh-public-ci added a comment.Nov 27 2019, 3:52 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/805/ for more details.

anlambert requested changes to this revision.Nov 27 2019, 3:58 PM
anlambert added a subscriber: anlambert.

The api is rate limited to 120 calls per hour in production so I think we should increase that value for that endpoint, as we did for api_origin_visit_latest.

The search engine is the main entry point to the archive content from the webapp so rate limit should not be reached when using it.

This revision now requires changes to proceed.Nov 27 2019, 3:58 PM
vlorentz added a comment.EditedNov 27 2019, 4:00 PM

What do you think the appropriate rate-limit is?

anlambert accepted this revision.Nov 27 2019, 4:04 PM

10/m should be enough I think

This revision is now accepted and ready to land.Nov 27 2019, 4:04 PM
vlorentz mentioned this in D2366: Increase rate-limit of swh_api_origin_search..Nov 27 2019, 4:10 PM
vlorentz added a comment.Nov 27 2019, 4:13 PM

Indeed. Someone using more than that will get rate-limited by the origin-visit endpoint anyway (which is 700/m)

swh-public-ci added a comment.Nov 27 2019, 4:13 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/404/ for more details.

Harbormaster completed remote builds in B9399: Diff 8328.Nov 27 2019, 4:13 PM
vlorentz mentioned this in D2368: Add throttle_scope swh_api_origin_search..Nov 27 2019, 4:27 PM
vlorentz updated this revision to Diff 8341.Nov 27 2019, 4:32 PM

rebase

This revision was landed with ongoing or failed builds.Nov 27 2019, 4:32 PM
Closed by commit rDWAPPS921236dae1e9: Remove 'internal' endpoint browse-origin-search. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDWAPPS921236dae1e9: Remove 'internal' endpoint browse-origin-search..
Harbormaster failed remote builds in B9411: Diff 8341!Nov 27 2019, 4:35 PM
swh-public-ci added a comment.Nov 27 2019, 4:35 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/809/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/809/console

swh-public-ci added a comment.Nov 27 2019, 4:41 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/408/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/408/console

Revision Contents
Changeset List

PathSize
swh/
web/
assets/
src/
bundles/
browse/
4 lines
browse/
views/
30 lines

Diff 8328

View Options

swh/web/assets/src/bundles/browse/origin-search.js

Loading...
View Options

swh/web/browse/views/origin.py

Loading...
About · Developer information · Legal