Page MenuHomeSoftware Heritage

Remove 'internal' endpoint browse-origin-search.
ClosedPublic

Authored by vlorentz on Nov 27 2019, 3:47 PM.

Details

Summary

The API does the same job.

Depends on D2363.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 27 2019, 3:47 PM
anlambert requested changes to this revision.Nov 27 2019, 3:58 PM
anlambert added a subscriber: anlambert.

The api is rate limited to 120 calls per hour in production so I think we should increase that value for that endpoint, as we did for api_origin_visit_latest.

The search engine is the main entry point to the archive content from the webapp so rate limit should not be reached when using it.

This revision now requires changes to proceed.Nov 27 2019, 3:58 PM
vlorentz added a comment.EditedNov 27 2019, 4:00 PM

What do you think the appropriate rate-limit is?

anlambert accepted this revision.Nov 27 2019, 4:04 PM

10/m should be enough I think

This revision is now accepted and ready to land.Nov 27 2019, 4:04 PM

Indeed. Someone using more than that will get rate-limited by the origin-visit endpoint anyway (which is 700/m)

This revision was landed with ongoing or failed builds.Nov 27 2019, 4:32 PM
This revision was automatically updated to reflect the committed changes.