Page MenuHomeSoftware Heritage
Differential D2295

db: check for existing snapshot when with_visit is True in origin_search()
ClosedPublic
Actions

Authored by douardda on Nov 18 2019, 12:28 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDSTOea9aa4736fa7: and not only for an existing origin visit.
Summary

and not only for an existing origin visit.

This is needed in situations where the snapshot table is not in sync with the
origin_visit one; typically occurs on mirrors.

Also add tests for with_visit argument.

Diff Detail

Repository
rDSTO Storage manager
Branch
fix-origin-query
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 9079
Build 13280: tox-on-jenkinsJenkins
Build 13279: arc lint + arc unit

Event Timeline

douardda created this revision.Nov 18 2019, 12:28 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 18 2019, 12:28 PM
swh-public-ci added a comment.Nov 18 2019, 12:30 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/785/ for more details.

Harbormaster completed remote builds in B9074: Diff 7885.Nov 18 2019, 12:30 PM
anlambert accepted this revision.Nov 18 2019, 1:14 PM
anlambert added a subscriber: anlambert.

Apart the sql upgrade file which should not be here, looks good to me.

sql/upgrades/144.sql
1 ↗(On Diff #7885)

Looks like that file was added by mistake

This revision is now accepted and ready to land.Nov 18 2019, 1:14 PM
douardda added a comment.Nov 18 2019, 1:26 PM
In D2295#53881, @anlambert wrote:

Apart the sql upgrade file which should not be here, looks good to me.

damnit! sorry

douardda updated this revision to Diff 7887.Nov 18 2019, 1:33 PM

remove sql migration file

swh-public-ci added a comment.Nov 18 2019, 1:36 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/786/ for more details.

Harbormaster completed remote builds in B9079: Diff 7887.Nov 18 2019, 1:36 PM
Closed by commit rDSTOea9aa4736fa7: and not only for an existing origin visit. (authored by douardda). · Explain WhyNov 18 2019, 1:38 PM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDSTOea9aa4736fa7: and not only for an existing origin visit..

Revision Contents
Changeset List

PathSize
swh/
storage/
7 lines
9 lines
tests/
95 lines

Diff 7887

View Options

swh/storage/db.py

Loading...
View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal