Depends on D2026.
Diff Detail
- Repository
- rDJNL Journal infrastructure
- Branch
- intrinsic-origin-metadata-client
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 7918 Build 11400: tox-on-jenkins Jenkins Build 11399: arc lint + arc unit
Event Timeline
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/271/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/271/console
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/273/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/273/console
swh/journal/client.py | ||
---|---|---|
23 | This default / accepted is unclear to me. At least before actually reading the code using theses. The comment is unclear, and should explain what 'default' stands for. | |
swh/journal/tests/test_client.py | ||
64–72 | Not sure this is really necessary. The key is not used in any way in this test, so an hardcoded value like producer.produce( topic=kafka_prefix + '.origin_intrinsic_metadata', key=key_to_kafka('some key'), value=value_to_kafka(value), ) would be enough and make the test easier to read. No need to 'obfuscate' the code with unneeded content. |