Page MenuHomeSoftware Heritage

Add support for origin_intrinsic_metadata in the journal client.
Changes PlannedPublic

Authored by vlorentz on Sep 23 2019, 3:30 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Summary

Depends on D2026.

Diff Detail

Repository
rDJNL Journal infrastructure
Branch
intrinsic-origin-metadata-client
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7920
Build 11404: tox-on-jenkinsJenkins
Build 11403: arc lint + arc unit

Event Timeline

vlorentz created this revision.Sep 23 2019, 3:30 PM
vlorentz planned changes to this revision.Oct 7 2019, 1:50 PM
douardda requested changes to this revision.Nov 8 2019, 11:16 AM
douardda added a subscriber: douardda.
douardda added inline comments.
swh/journal/client.py
23

This default / accepted is unclear to me. At least before actually reading the code using theses.

The comment is unclear, and should explain what 'default' stands for.

swh/journal/tests/test_client.py
65–73

Not sure this is really necessary. The key is not used in any way in this test, so an hardcoded value like

producer.produce(
    topic=kafka_prefix + '.origin_intrinsic_metadata',
    key=key_to_kafka('some key'),
    value=value_to_kafka(value),
)

would be enough and make the test easier to read. No need to 'obfuscate' the code with unneeded content.