Part two of D2015. See the description of that diff for more details.
Details
Details
- Reviewers
vlorentz - Group Reviewers
Reviewers - Commits
- rDMOD70e5d50a121b: identifiers.py: do not inherit from on-the-fly namedtuple
rDMOD54c664267640: mypy: ignore django-stubs, needed only by hypothesis
rDMOD267ffeeacbce: mypy.ini: remove left-over sample section
rDMOD491dcc599dbf: typing: minimal changes to make a no-op mypy run pass
Diff Detail
Diff Detail
- Repository
- rDMOD Data model
- Branch
- feature/typing
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 7879 Build 11341: tox-on-jenkins Jenkins Build 11340: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/125/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/126/ for more details.
Comment Actions
- mypy: ignore django-stubs, needed only by hypothesis
- identifiers.py: do not inherit from on-the-fly namedtuple
swh/model/hashutil.py | ||
---|---|---|
74 | There doesn't seem to be a proper public abstract type for the hashes returned by hashlib: they're _hashlib.HASH and I'd rather not use a private module in a type definition. | |
swh/model/merkle.py | ||
113 | agreed, but not in this diff, right? I've added an inline TODO now though. |
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/127/ for more details.