Page MenuHomeSoftware Heritage
Differential D1886

Remove release metadata from serialization if it's None.
ClosedPublic
Actions

Authored by vlorentz on Aug 21 2019, 5:50 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDMOD6df68b0fb5ea: Remove release metadata from serialization if it's None.
Summary

It kind of matches the current state of the postgresql storage, which
does not support it.

Diff Detail

Repository
rDMOD Data model
Branch
release-metadata2
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7378
Build 10497: tox-on-jenkinsJenkins
Build 10496: arc lint + arc unit

Event Timeline

vlorentz created this revision.Aug 21 2019, 5:50 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 21 2019, 5:50 PM
vlorentz added a child revision: D1874: Make revision_add and release_add validate their input..Aug 21 2019, 5:50 PM
swh-public-ci added a comment.Aug 21 2019, 5:50 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/114/ for more details.

Harbormaster completed remote builds in B7362: Diff 6325.Aug 21 2019, 5:50 PM
olasd accepted this revision.Aug 22 2019, 1:59 PM
olasd added a subscriber: olasd.

As I said f2f the metadata field on releases isn't implemented yet (the postgres storage will ignore it), but this is something we'll probably need to add as part of T1258.

This revision is now accepted and ready to land.Aug 22 2019, 1:59 PM
vlorentz updated this revision to Diff 6341.Aug 22 2019, 2:02 PM

rebase

This revision was landed with ongoing or failed builds.Aug 22 2019, 2:02 PM
Closed by commit rDMOD6df68b0fb5ea: Remove release metadata from serialization if it's None. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B7378: Diff 6341!Aug 22 2019, 2:02 PM
swh-public-ci added a comment.Aug 22 2019, 2:02 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tox/117/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tox/117/console

vlorentz removed a child revision: D1874: Make revision_add and release_add validate their input..Aug 22 2019, 3:37 PM
vlorentz added a child revision: D1874: Make revision_add and release_add validate their input..Aug 29 2019, 11:34 AM

Revision Contents
Changeset List

PathSize
swh/
model/
2 lines

Diff 6341

View Options

swh/model/model.py

Loading...
About · Developer information · Legal