Differential D1735

api: properly use deprecated for class renamings
ClosedPublic
Actions

Authored by douardda on Jul 15 2019, 12:04 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDCORE13c18d781628: api: properly use deprecated for class renamings

Summary

the deprecated decorator for classes does not return a new class, it only
inject a modified new method, so we indeed need a new class object
in this case of class renaming.

Diff Detail

Repository

rDCORE Foundations and core functionalities

Branch

fix-deprecated

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 6870
Build 9626: tox-on-jenkins	Jenkins
Build 9625: arc lint + arc unit

Event Timeline

douardda created this revision.Jul 15 2019, 12:04 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 15 2019, 12:04 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCORE/job/tox/261/ for more details.

Harbormaster completed remote builds in B6864: Diff 5825.Jul 15 2019, 12:08 PM

vlorentz accepted this revision.Jul 15 2019, 2:59 PM

This revision is now accepted and ready to land.Jul 15 2019, 2:59 PM

rebased

This revision was landed with ongoing or failed builds.Jul 15 2019, 3:36 PM

Closed by commit rDCORE13c18d781628: api: properly use deprecated for class renamings (authored by douardda). · Explain Why

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B6870: Diff 5831!Jul 15 2019, 3:36 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tox/266/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tox/266/console

Revision Contents
Changeset List

Path

Size

swh/

core/

api/

__init__.py

23 lines

asynchronous.py

7 lines

Diff 5831

View Options

swh/core/api/init.py

View Options

swh/core/api/asynchronous.py

api: properly use deprecated for class renamingsClosedPublicActions