Page MenuHomeSoftware Heritage
Differential D1695

Remove the legacy behavior of snapshot_add (which updates a visit).
ClosedPublic
Actions

Authored by vlorentz on Jul 8 2019, 2:29 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSTOC6b68fc4df437: Remove the legacy behavior of snapshot_add (which updates a visit).
rDSTO6b68fc4df437: Remove the legacy behavior of snapshot_add (which updates a visit).
Summary

We stopped using it a while ago by now.

Diff Detail

Repository
rDSTO Storage manager
Branch
kill-legacy-snapshot-add
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6722
Build 9392: tox-on-jenkinsJenkins
Build 9391: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jul 8 2019, 2:29 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 8 2019, 2:29 PM
vlorentz mentioned this in D1696: Fix/silence warnings..Jul 8 2019, 2:30 PM
swh-public-ci added a comment.Jul 8 2019, 2:32 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/546/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/546/console

Harbormaster failed remote builds in B6719: Diff 5697!Jul 8 2019, 2:33 PM
ardumont added a subscriber: ardumont.Jul 8 2019, 2:36 PM

Looks good minus the tests failure.
I'll wait for the tests fix to accept it though ;)

vlorentz updated this revision to Diff 5700.Jul 8 2019, 2:39 PM
  • rebase
  • fix tests
swh-public-ci added a comment.Jul 8 2019, 2:42 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/548/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/548/console

Harbormaster failed remote builds in B6722: Diff 5700!Jul 8 2019, 2:42 PM
swh-public-ci added a comment.Jul 8 2019, 2:47 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/549/ for more details.

Harbormaster completed remote builds in B6722: Diff 5700.Jul 8 2019, 2:47 PM
ardumont accepted this revision.Jul 8 2019, 2:55 PM
This revision is now accepted and ready to land.Jul 8 2019, 2:55 PM
Closed by commit rDSTO6b68fc4df437: Remove the legacy behavior of snapshot_add (which updates a visit). (authored by vlorentz). · Explain WhyJul 8 2019, 2:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
storage/
api/
20 lines
2 lines
20 lines
29 lines
tests/
algos/
8 lines
260 lines

Diff 5700

View Options

swh/storage/api/client.py

Loading...
View Options

swh/storage/api/server.py

Loading...
View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/storage.py

Loading...
View Options

swh/storage/tests/algos/test_snapshot.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal