Details

Reviewers

Group Reviewers

Commits

rDSTOCf0853ac4d0d5: Merge id/url tests using an arg provided by hypothesis.
rDSTOf0853ac4d0d5: Merge id/url tests using an arg provided by hypothesis.

Summary

Makes the test code shorter.

Depends on D1654 and D1663.

Diff Detail

Repository

rDSTO Storage manager

Branch

proptest-use_url

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 6599
Build 9207: tox-on-jenkins	Jenkins
Build 9206: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jun 28 2019, 8:50 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 28 2019, 8:50 PM

vlorentz edited the summary of this revision. (Show Details)Jun 28 2019, 8:52 PM

vlorentz added parent revisions: D1663: Add a 'reset' endpoint to the in-mem storage., D1654: Add an 'origin_visit_find_by_date' endpoint..

vlorentz added a child revision: D1665: Make all endpoints support origin urls instead of ids..Jun 28 2019, 8:53 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/514/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/514/console

Harbormaster failed remote builds in B6576: Diff 5569!Jun 28 2019, 9:00 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/516/ for more details.

Harbormaster completed remote builds in B6576: Diff 5569.Jun 28 2019, 9:26 PM

vlorentz mentioned this in D1663: Add a 'reset' endpoint to the in-mem storage..Jul 1 2019, 2:04 PM

Looks good to me.

swh/storage/tests/test_storage.py
1573	Just a nitpick: I would use an `origin` variable here instead of duplicating the `if else` instruction
2779	Same here.

This revision is now accepted and ready to land.Jul 1 2019, 2:59 PM

use variable instead of ternary

minor fix

Build was aborted

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/519/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/519/console

Harbormaster failed remote builds in B6598: Diff 5590!Jul 1 2019, 3:06 PM

anlambert mentioned this in D1665: Make all endpoints support origin urls instead of ids..Jul 1 2019, 3:08 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/520/ for more details.

Harbormaster completed remote builds in B6599: Diff 5591.Jul 1 2019, 3:21 PM

rebase

This revision was landed with ongoing or failed builds.Jul 1 2019, 3:52 PM

Closed by commit rDSTOf0853ac4d0d5: Merge id/url tests using an arg provided by hypothesis. (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B6610: Diff 5602!Jul 1 2019, 4:10 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/527/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/527/console

Merge id/url tests using an arg provided by hypothesis.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 5591

swh/storage/in_memory.py

swh/storage/storage.py

swh/storage/tests/storage_testing.py

swh/storage/tests/test_api_client.py

swh/storage/tests/test_in_memory.py

swh/storage/tests/test_storage.py

Merge id/url tests using an arg provided by hypothesis.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5591

swh/storage/in_memory.py

swh/storage/storage.py

swh/storage/tests/storage_testing.py

swh/storage/tests/test_api_client.py

swh/storage/tests/test_in_memory.py

swh/storage/tests/test_storage.py

Merge id/url tests using an arg provided by hypothesis.
ClosedPublic
Actions

Revision Contents
Changeset List