Close T1823
Details
Details
Unit tests added
Diff Detail
Diff Detail
- Repository
- rDOBJS Object storage
- Branch
- feature/fdatasync
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 6346 Build 8796: tox-on-jenkins Jenkins Build 8795: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DOBJS/job/tox/64/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJS/job/tox/64/console
| swh/objstorage/backends/pathslicing.py | ||
|---|---|---|
| 135 | Is this because some python versions don't have it, or just for OS portability? I'm asking because we now have evidence (in T1817) that fdatasync is critical for us, in the sense that we can lose data if it's not available. So just silently ignoring the fact it's not available makes me shiver :-) I'm tempted to suggest failing to initialize if fdatasync is not available. Either way, we should log an error message if it's not available. | |
Comment Actions
Fallback to fsync if fdatasync isn't available
| swh/objstorage/backends/pathslicing.py | ||
|---|---|---|
| 135 | The new version falls back to fsync (available on all platforms) if fdatasync isn't available. | |
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DOBJS/job/tox/65/
See console output for more information: https://jenkins.softwareheritage.org/job/DOBJS/job/tox/65/console
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DOBJS/job/tox/66/ for more details.