Page MenuHomeSoftware Heritage
Differential D1604

Use origin urls instead of origin ids (swh-loader-mercurial)
ClosedPublic
Actions

Authored by vlorentz on Jun 18 2019, 4:23 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDLDHG038f5ea7ec8d: Use origin urls instead of origin ids.
Summary

Depends D1603

Diff Detail

Repository
rDLDHG Mercurial loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jun 18 2019, 4:23 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 18 2019, 4:23 PM
vlorentz mentioned this in T1816: Make all clients of swh-storage use origin URL as identifier and use visit types instead of origin types.Jun 18 2019, 4:23 PM
swh-public-ci added a comment.Jun 18 2019, 4:25 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDHG/job/tox/26/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDHG/job/tox/26/console

Harbormaster failed remote builds in B6297: Diff 5313!Jun 18 2019, 4:25 PM
swh-public-ci added a comment.Jun 19 2019, 9:37 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDHG/job/tox/27/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDHG/job/tox/27/console

ardumont requested changes to this revision.EditedJun 19 2019, 9:38 AM
ardumont added a subscriber: ardumont.

For the build failure which i think i saw the reason, check the extra 'v' in the requirements-swh.txt.

Jenkins seems to agree with me:

ERROR: No matching distribution found for swh.loader.core>=v0.0.43 (from swh.loader.mercurial==0.0.16.post4)
requirements-swh.txt
4

Drop the v, i think that's the build's failure reason.

This revision now requires changes to proceed.Jun 19 2019, 9:38 AM
ardumont edited the summary of this revision. (Show Details)Jun 19 2019, 9:55 AM
ardumont added inline comments.
requirements-swh.txt
4

Not only that anyway, since we need to tag the loader-core.

vlorentz updated this revision to Diff 5337.Jun 19 2019, 11:34 AM

fix version string

swh-public-ci added a comment.Jun 19 2019, 11:37 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLDHG/job/tox/28/ for more details.

Harbormaster completed remote builds in B6320: Diff 5337.Jun 19 2019, 11:37 AM
ardumont accepted this revision.Jun 19 2019, 11:44 AM
This revision is now accepted and ready to land.Jun 19 2019, 11:44 AM
Closed by commit rDLDHG038f5ea7ec8d: Use origin urls instead of origin ids. (authored by vlorentz). · Explain WhyJun 19 2019, 11:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
2 lines
swh/
loader/
mercurial/
2 lines
tests/
10 lines

Diff 5338

View Options

requirements-swh.txt

Loading...
View Options

swh/loader/mercurial/loader.py

Loading...
View Options

swh/loader/mercurial/tests/test_loader.py

Loading...
About · Developer information · Legal