Page MenuHomeSoftware Heritage
Differential D1603

Use origin urls instead of origin ids (swh-loader-core)
ClosedPublic
Actions

Authored by vlorentz on Jun 18 2019, 4:22 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDLDBASE35992bf7a8fc: Use origin urls instead of origin ids.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jun 18 2019, 4:22 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 18 2019, 4:22 PM
vlorentz mentioned this in T1816: Make all clients of swh-storage use origin URL as identifier and use visit types instead of origin types.Jun 18 2019, 4:23 PM
swh-public-ci added a comment.Jun 18 2019, 4:26 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/114/ for more details.

Harbormaster completed remote builds in B6294: Diff 5312.Jun 18 2019, 4:26 PM
ardumont accepted this revision.Jun 19 2019, 9:41 AM
ardumont added a subscriber: ardumont.

Sounds good (also clearer).

swh/loader/core/loader.py
240

Maybe drop the 'type' now (i mean only in the log messages calls, here and up above in the same method).

This revision is now accepted and ready to land.Jun 19 2019, 9:41 AM
ardumont mentioned this in D1607: Remove argument origin_id from call to Loader.send_origin_metadata..Jun 19 2019, 9:54 AM
ardumont mentioned this in D1604: Use origin urls instead of origin ids (swh-loader-mercurial).
vlorentz added inline comments.Jun 19 2019, 10:37 AM
swh/loader/core/loader.py
240

I'll do that in an other set of diffs

ardumont added inline comments.Jun 19 2019, 10:38 AM
swh/loader/core/loader.py
240

sure thing, that was a proposal to gain a bit ;)

Closed by commit rDLDBASE35992bf7a8fc: Use origin urls instead of origin ids. (authored by vlorentz). · Explain WhyJun 19 2019, 11:25 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
loader/
core/
4 lines
71 lines
tests/
2 lines
4 lines
3 lines

Diff 5336

View Options

swh/loader/core/converters.py

Loading...
View Options

swh/loader/core/loader.py

Loading...
View Options

swh/loader/core/tests/__init__.py

Loading...
View Options

swh/loader/core/tests/test_converters.py

Loading...
View Options

swh/loader/core/tests/test_loader.py

Loading...
About · Developer information · Legal