Page MenuHomeSoftware Heritage
Differential D1591

Missing triple back quote after lister-gnu in README of lister added (T1813)
ClosedPublic
Actions

Authored by NancyChauhan on Jun 16 2019, 2:59 PM.

Details

Reviewers
zack
nahimilega
ardumont
Group Reviewers
Reviewers
Commits
rDLS83b3a75f11a6: README: Add missing triple back quote
Required Signatures
L3 Software Heritage Contributor License Agreement, version 1.0

Diff Detail

Repository
rDLS Listers
Branch
documentation
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6246
Build 8637: tox-on-jenkinsJenkins
Build 8636: arc lint + arc unit

Event Timeline

NancyChauhan created this revision.Jun 16 2019, 2:59 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 16 2019, 2:59 PM
Herald added a required legal document: L3 Software Heritage Contributor License Agreement, version 1.0. · View Herald Transcript
swh-public-ci added a comment.Jun 16 2019, 3:04 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/193/ for more details.

Harbormaster completed remote builds in B6240: Diff 5264.Jun 16 2019, 3:04 PM
NancyChauhan added reviewers: zack, nahimilega.Jun 16 2019, 3:09 PM
NancyChauhan added a comment.Jun 16 2019, 3:12 PM

Solves T1813

nahimilega added inline comments.Jun 16 2019, 4:04 PM
README.md
193

You need to add a blank line after triple backquote.

196

While we are at it please also change RCRAN to CRAN.

nahimilega added a comment.Jun 16 2019, 4:17 PM

Also, please refer to https://wiki.softwareheritage.org/wiki/Git_style_guide

NancyChauhan updated this revision to Diff 5265.Jun 16 2019, 4:32 PM
  • Typo error Corrected
NancyChauhan marked 2 inline comments as done.Jun 16 2019, 4:37 PM
In D1591#35964, @nahimilega wrote:

Also, please refer to https://wiki.softwareheritage.org/wiki/Git_style_guide

Thank you . I have done the required changes

swh-public-ci added a comment.Jun 16 2019, 4:37 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/194/ for more details.

Harbormaster completed remote builds in B6241: Diff 5265.Jun 16 2019, 4:37 PM
ardumont requested changes to this revision.Jun 17 2019, 10:13 AM
ardumont added a subscriber: ardumont.

Please:

  • squash your commits together
  • use an imperative form, something like: "README: Add missing triple back quote"
This revision now requires changes to proceed.Jun 17 2019, 10:13 AM
NancyChauhan updated this revision to Diff 5269.Jun 17 2019, 10:34 AM
This comment was removed by NancyChauhan.
swh-public-ci added a comment.Jun 17 2019, 10:39 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/195/ for more details.

Harbormaster completed remote builds in B6246: Diff 5269.Jun 17 2019, 10:39 AM
ardumont accepted this revision.Jun 17 2019, 10:39 AM

Thank you both @NancyChauhan @nahimilega

This revision is now accepted and ready to land.Jun 17 2019, 10:39 AM
NancyChauhan added a comment.Jun 17 2019, 11:24 AM
In D1591#35994, @ardumont wrote:

Thank you both @NancyChauhan @nahimilega

I am having following error when i am trying to Land my change onto master after git push :

fatal: unable to access 'https://forge.softwareheritage.org/source/swh-lister.git/': The requested URL returned error: 403

vlorentz added a subscriber: vlorentz.EditedJun 17 2019, 3:11 PM

@NancyChauhan You must change the push URL: https://wiki.softwareheritage.org/wiki/Code_review_in_Phabricator#SSH_key_for_pushes

NancyChauhan updated this revision to Diff 5325.Jun 19 2019, 8:15 AM

README.md : Missing triple back quote after lister-gnu in README of lister added

Harbormaster completed remote builds in B6308: Diff 5325.Jun 19 2019, 8:19 AM
swh-public-ci added a comment.Jun 19 2019, 8:19 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/203/ for more details.

Closed by commit rDLS83b3a75f11a6: README: Add missing triple back quote (authored by NancyChauhan). · Explain WhyJun 19 2019, 8:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
5 lines

Diff 5269

View Options

README.md

Loading...
About · Developer information · Legal