Refactor content_add's code into smaller functions.
ClosedPublic
Actions

Authored by vlorentz on Apr 4 2019, 3:53 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDSTO591371869eec: Refactor content_add's code into smaller functions.

Diff Detail

Repository

rDSTO Storage manager

Branch

refactor-content-add

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 5109
Build 6865: tox-on-jenkins	Jenkins
Build 6864: arc lint + arc unit

Event Timeline

vlorentz created this revision.Apr 4 2019, 3:53 PM

vlorentz added a child revision: D1344: Add a new endpoint content_add_metadata..

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/292/ for more details.

Harbormaster completed remote builds in B5101: Diff 4299.Apr 4 2019, 4:03 PM

olasd accepted this revision.Apr 4 2019, 5:09 PM

olasd added inline comments.

swh/storage/storage.py
159	I think that's missing a "from None" to avoid getting a double-traceback?

This revision is now accepted and ready to land.Apr 4 2019, 5:09 PM

rebase
from None

vlorentz marked an inline comment as done.Apr 4 2019, 5:12 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/295/ for more details.

Harbormaster completed remote builds in B5109: Diff 4306.Apr 4 2019, 5:16 PM

Closed by commit rDSTO591371869eec: Refactor content_add's code into smaller functions. (authored by vlorentz). · Explain WhyApr 4 2019, 5:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

storage/

storage.py

167 lines

Diff 4306

View Options

Refactor content_add's code into smaller functions.ClosedPublicActions