Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/344/ for more details.

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/345/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/345/console

@kalpitk, thanks for handling this. At first, I wanted to implement this using url redirection
but simply relying on the application route regexps is indeed simpler.

In the code you have submitted so far, there is no need to convert the input sha1 parameters
to lowercase, there will be correctly converted to their bytes representation by dedicated
functions from the swh stack.

Can you also add support for uppercase sha1s in the api part of swh-web ?

Last but not least, adding tests for these new features is a requirement before I can
land this diff.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/346/ for more details.

@anlambert I'll update for api endpoints also.

I am currently unfamiliar with writing tests for django, so may take some time.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/349/ for more details.

@anlambert Oh i didn't read your comment. Anyways, I just wrote some tests.

Many tests assert that the page has same sha1 as passed in url. This would fail tests for sha1 in uppercase.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/350/ for more details.

In D1290#27514, @anlambert wrote:

@kalpitk, I am ok with your tests plan but there is still some work to do here:

• remove the calls to the lower method inside endpoint implementations (as I said, this is not needed)
• there is numerous other endpoints that need to be processed (simply search for [0-9a-f] inside the swh-web codebase to identify them)
• tests implementation must be factorized as test_* and test_*_with_uppercase_sha1 are basically the same thing

I didnt't get the third point.

I didnt't get the third point.

For your test implementations, you simply duplicated the code from the test_* method and change the sha1 parameters
to their uppercase version. But code duplication is not a good practice as it complicates future code maintenance.

For instance in swh/web/browse/views/test_release.py, the tests can be factorized using a new "private" method,
see below:

def _release_browse_test(self, release):
    url = reverse('browse-release',
                  url_args={'sha1_git': release})

    release_data = self.release_get(release)
    # release may contain uppercase characters in it
    release_data['id'] = release

    resp = self.client.get(url)

    self._release_browse_checks(resp, release_data)

@given(release())
def test_release_browse(self, release):
    self._release_browse_test(release)

@given(release())
def test_release_browse_with_uppercase_sha1(self, release):
    self._release_browse_test(release.upper())

In D1290#27514, @anlambert wrote:

@kalpitk, I am ok with your tests plan but there is still some work to do here:

• remove the calls to the lower method inside endpoint implementations (as I said, this is not needed)
• there is numerous other endpoints that need to be processed (simply search for [0-9a-f] inside the swh-web codebase to identify them)
• tests implementation must be factorized as test_* and test_*_with_uppercase_sha1 are basically the same thing

And regarding first, I had removed lower calls when hash_to_hex was called. Where else I should remove those calls?

And regarding first, I had removed lower calls when hash_to_hex was called. Where else I should remove those calls?

You have to remove them everywhere and adapt tests if needed as I pointed it for the browse/release case.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/351/ for more details.

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/352/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/352/console

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/353/ for more details.

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/355/ for more details.

@kalpitk , after some brainstorming on how to easily add url redirections for uppercase sha1s, I ended up
with the following solution showcased in that separate branch: https://forge.softwareheritage.org/source/swh-web/history/redirect_upper_sha1/

I did not handle all endpoints so far neither updated the tests (which in these case will simply consist to check that
url redirection have been performed). Can you update that diff (or abandon this one in favor of a new one) using
the proposed approach ?

I have updated the commit in https://forge.softwareheritage.org/source/swh-web/history/redirect_upper_sha1/ by addding some tests.