Page MenuHomeSoftware Heritage
Differential D112

Begin archive 'integration'
ClosedPublic
Actions

Authored by jbertran on Aug 31 2016, 4:01 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
R65:63f696944e77: html: use url_for, fix tabulation issues
R65:efa994980d92: Changes from feedback - D112
R65:0edda1d79972: browse, main: change web ui nav flow
R65:63c386cca791: html: add navbar to layout
R65:b67158797ae7: Create browsing view landing page
R65:0cb53b7e2282: css: add custom styling for bootstrap issues
R65:2f6f1bfd8f65: Create directory for HTML snippets
rDWAPPSb67158797ae7: Create browsing view landing page
rDWAPPSefa994980d92: Changes from feedback - D112
rDWAPPS0cb53b7e2282: css: add custom styling for bootstrap issues
rDWAPPS63c386cca791: html: add navbar to layout
rDWAPPS0edda1d79972: browse, main: change web ui nav flow
rDWAPPS63f696944e77: html: use url_for, fix tabulation issues
rDWAPPS2f6f1bfd8f65: Create directory for HTML snippets
Summary

Create directory for HTML snippets

  • Snippets are in templates/includes
  • Create snippets for origin, revision and directory search

Create browsing view landing page
css: add custom styling for bootstrap issues
html: add navbar to layout
browse, main: change web ui nav flow

Diff Detail

Repository
rDWAPPS Web applications
Branch
IntegrationChanges
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 452
Build 663: Software Heritage Python tests
Build 662: arc lint + arc unit

Event Timeline

jbertran updated this revision to Diff 379.Aug 31 2016, 4:01 PM
jbertran retitled this revision from to Begin archive 'integration'.
jbertran updated this object.
jbertran edited the test plan for this revision. (Show Details)
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 31 2016, 4:01 PM
olasd added a subscriber: olasd.Aug 31 2016, 4:07 PM

These changes look reasonable.

I haven't looked in detail at the contents of the HTML, but I see some inconsistencies in indentation, as well as in the javascript (mixed spaces and tabs?).

All the internal hrefs should use url_for, so that we can move them without breaking everything.

swh/web/ui/templates/layout.html
33–37

those hrefs should probably be url_fors

jbertran added a comment.Aug 31 2016, 4:09 PM
In D112#2731, @olasd wrote:

but I see some inconsistencies in indentation, as well as in the javascript (mixed spaces and tabs?).

*Internal scream*

Thanks :)

jbertran updated this revision to Diff 380.Aug 31 2016, 4:21 PM
jbertran edited edge metadata.

html: use url_for, fix tabulation issues

Herald edited edge metadata. · View Herald TranscriptAug 31 2016, 4:21 PM
jbertran updated this revision to Diff 381.Aug 31 2016, 4:53 PM
jbertran edited edge metadata.

Correct a bug in search-form.html

Herald edited edge metadata. · View Herald TranscriptAug 31 2016, 4:53 PM
jbertran updated this revision to Diff 382.Sep 1 2016, 3:02 PM
jbertran edited edge metadata.

Rebase onto master

Herald edited edge metadata. · View Herald TranscriptSep 1 2016, 3:02 PM
jbertran updated this revision to Diff 383.Sep 2 2016, 10:02 AM
jbertran edited edge metadata.

Rebase onto master (2)

Herald edited edge metadata. · View Herald TranscriptSep 2 2016, 10:02 AM
ardumont edited reviewers, added: ardumont; removed: Reviewers.Sep 2 2016, 10:14 AM
ardumont requested changes to this revision.Sep 2 2016, 10:35 AM
ardumont edited edge metadata.

Ok, this sounds almost perfect.
The results are really awesome!

Can you please fix the 2-3 minor nitpicks?

Thanks.

Coffee?

swh/web/ui/static/css/style.css
69

Can you please reference the issue from where you copied?

swh/web/ui/templates/browse.html
49

Beware the indentation ^^

swh/web/ui/templates/home.html
0

If this is no longer reachable since there is a redirect now.
This can be removed.

swh/web/ui/templates/layout.html
29

Seen with @jbertran: Please, fix id to #swh-navbar-collapse

This revision now requires changes to proceed.Sep 2 2016, 10:35 AM
jbertran marked 4 inline comments as done.Sep 2 2016, 10:57 AM
jbertran updated this revision to Diff 384.Sep 2 2016, 11:00 AM
jbertran edited edge metadata.

Changes from @ardumont 's feedback

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 2 2016, 11:00 AM
ardumont accepted this revision.Sep 2 2016, 11:03 AM
ardumont edited edge metadata.
This revision is now accepted and ready to land.Sep 2 2016, 11:03 AM
Closed by commit rDWAPPS2f6f1bfd8f65: Create directory for HTML snippets (authored by jbertran). · Explain WhySep 2 2016, 11:06 AM
This revision was automatically updated to reflect the committed changes.
jbertran mentioned this in rDWAPPSefa994980d92: Changes from feedback - D112.
jbertran mentioned this in R65:efa994980d92: Changes from feedback - D112.Feb 23 2019, 1:55 AM

Revision Contents
Changeset List

PathSize
swh/
web/
ui/
static/
css/
38 lines
templates/
2 lines
56 lines
includes/
111 lines
57 lines
66 lines
includes/
40 lines
86 lines
60 lines
2 lines
tests/
views/
53 lines
16 lines
views/
9 lines
4 lines

Diff 384

View Options

swh/web/ui/static/css/style.css

Loading...
View Options

swh/web/ui/templates/api.html

Loading...
View Options

swh/web/ui/templates/browse.html

Loading...
View Options

swh/web/ui/templates/home.html

Loading...
View Options

swh/web/ui/templates/includes/home-directory.html

Loading...
View Options

swh/web/ui/templates/includes/home-origin.html

Loading...
View Options

swh/web/ui/templates/includes/home-revision.html

Loading...
View Options

swh/web/ui/templates/includes/search-form.html

Loading...
View Options

swh/web/ui/templates/layout.html

Loading...
View Options

swh/web/ui/templates/origin.html

Loading...
View Options

swh/web/ui/templates/search-form.html

Loading...
View Options

swh/web/ui/templates/search.html

Loading...
View Options

swh/web/ui/tests/views/test_browse.py

Loading...
View Options

swh/web/ui/tests/views/test_main.py

Loading...
View Options

swh/web/ui/views/browse.py

Loading...
View Options

swh/web/ui/views/main.py

Loading...
About · Developer information · Legal