Page MenuHomeSoftware Heritage

Begin archive 'integration'
ClosedPublic

Authored by jbertran on Aug 31 2016, 4:01 PM.

Diff Detail

Repository
rDWAPPS Web applications
Branch
IntegrationChanges
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 434
Build 640: Software Heritage Python tests
Build 639: arc lint + arc unit

Event Timeline

jbertran retitled this revision from to Begin archive 'integration'.
jbertran updated this object.
jbertran edited the test plan for this revision. (Show Details)

These changes look reasonable.

I haven't looked in detail at the contents of the HTML, but I see some inconsistencies in indentation, as well as in the javascript (mixed spaces and tabs?).

All the internal hrefs should use url_for, so that we can move them without breaking everything.

swh/web/ui/templates/layout.html
34–38

those hrefs should probably be url_fors

In D112#2731, @olasd wrote:

but I see some inconsistencies in indentation, as well as in the javascript (mixed spaces and tabs?).

*Internal scream*

Thanks :)

jbertran edited edge metadata.

html: use url_for, fix tabulation issues

jbertran edited edge metadata.

Correct a bug in search-form.html

jbertran edited edge metadata.

Rebase onto master

jbertran edited edge metadata.

Rebase onto master (2)

ardumont edited edge metadata.

Ok, this sounds almost perfect.
The results are really awesome!

Can you please fix the 2-3 minor nitpicks?

Thanks.

Coffee?

swh/web/ui/static/css/style.css
66

Can you please reference the issue from where you copied?

swh/web/ui/templates/browse.html
49

Beware the indentation ^^

swh/web/ui/templates/home.html
12

If this is no longer reachable since there is a redirect now.
This can be removed.

swh/web/ui/templates/layout.html
29

Seen with @jbertran: Please, fix id to #swh-navbar-collapse

This revision now requires changes to proceed.Sep 2 2016, 10:35 AM
jbertran edited edge metadata.

Changes from @ardumont 's feedback

ardumont edited edge metadata.
This revision is now accepted and ready to land.Sep 2 2016, 11:03 AM
This revision was automatically updated to reflect the committed changes.