Differential D1074

automatic-backport: Add detailed steps
AbandonedPublic
Actions

Authored by ardumont on Feb 4 2019, 3:03 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Summary

Png export sample:

(updated)

Depends on D1073

Test Plan

make -C docs/images/automatic-backport.svg

Diff Detail

Repository

rCJSWH Jenkins jobs

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 3995
Build 5240: arc lint + arc unit

Event Timeline

ardumont created this revision.Feb 4 2019, 3:03 PM

Harbormaster completed remote builds in B3995: Diff 3384.Feb 4 2019, 3:03 PM

ardumont edited the summary of this revision. (Show Details)Feb 4 2019, 3:04 PM

ardumont added a project: Packagers.

Inconsistent capitalization. Other than that, lgtm

Update

Harbormaster completed remote builds in B4005: Diff 3387.Feb 4 2019, 3:45 PM

ardumont edited the summary of this revision. (Show Details)Feb 4 2019, 3:46 PM

closing in favor of not yet landed https://krkr.eu/debian-swh-packages.png

ardumont mentioned this in D1098: Add documentation for the (current status of) automated debian jobs.Feb 7 2019, 7:32 PM

Revision Contents
Changeset List

Path

Size

docs/

images/

automatic-backport.uml

27 lines

Diff 3384

View Options

docs/images/automatic-backport.uml

This file was added.

				# Copyright (C) 2021 The Software Heritage developers
				# See the AUTHORS file at the top-level directory of this distribution
				# License: GNU General Public License version 3, or any later version
				# See top-level LICENSE file for more information
				ardumontAuthorUnsubmitted Done Inline Actions /me will play fill in the blank ardumont: /me will play fill in the blank

				from datetime import datetime, timezone
				from typing import Dict, Optional

				from swh.icinga_plugins.save_code_now import REPORT_MSG, SaveCodeNowCheck

				from .utils import invoke
				from .web_scenario import WebScenario


				def fake_response(
				origin: str,
				visit_type: str,
				sor_status: str = "pending",
				task_status: Optional[str] = None,
				) -> Dict:
				"""Fake a save code now request api response"""
				visit_date = None
				if task_status in ("failed", "succeeded"):
				visit_date = str(datetime.now(tz=timezone.utc))

				return {
				"visit_type": visit_type,
				"origin_url": origin,
				"save_request_date": "to-replace",
				"save_request_status": sor_status,
				"save_task_status": task_status,
				"visit_date": visit_date,
				}


				def test_save_code_now_immediate_success(requests_mock, mocker, mocked_time):
				scenario = WebScenario()

				origin = "fake-origin-url"
				visit_type = "svn"
				origin_info = (visit_type, origin)

				root_api_url = "mock://swh-web.example.org"
				api_url = SaveCodeNowCheck.api_url_scn(root_api_url, origin, visit_type)

				# creation request
				scenario.add_step(
				"post",
				api_url,
				vsellierUnsubmitted Not Done Inline Actions The return of the random ;) vsellier: The return of the random ;)
				fake_response(origin, visit_type, "accepted", "not yet scheduled"),
				)
				response_scheduled = fake_response(origin, visit_type, "accepted", "scheduled")
				# status polling requests
				scenario.add_step("get", api_url, [response_scheduled])
				# sometimes we can have multiple response so we fake that here
				scenario.add_step("get", api_url, [response_scheduled, response_scheduled])
				scenario.add_step(
				"get", api_url, [fake_response(origin, visit_type, "accepted", "succeeded")]
				)
				scenario.install_mock(requests_mock)

				# fmt: off
				result = invoke(
				[
				"check-savecodenow", "--swh-web-url", root_api_url,
				"origin", origin,
				"--visit-type", visit_type,
				]
				)
				# fmt: on

				assert result.output == (
				f"{SaveCodeNowCheck.TYPE} OK - {REPORT_MSG} {origin_info} took "
				f"30.00s and succeeded.\n"
				f"\| 'total_time' = 30.00s\n"
				)
				assert result.exit_code == 0, result.output


				def test_save_code_now_pending_state_unsupported(requests_mock, mocker, mocked_time):
				"""Pending save requests are not supported in the test so they should fail early

				Pending requests are requests that need a moderator to accept the repository into
				the save code now flow.

				Do not actually use such origin to trigger the checks.

				"""
				scenario = WebScenario()

				origin = "fake-origin-git"
				visit_type = "git"
				origin_info = (visit_type, origin)

				root_api_url = "mock://swh-web2.example.org"
				api_url = SaveCodeNowCheck.api_url_scn(root_api_url, origin, visit_type)

				# creation request
				scenario.add_step(
				"post", api_url, fake_response(origin, visit_type, "pending", "not created"),
				)
				scenario.install_mock(requests_mock)

				# fmt: off
				result = invoke(
				[
				"check-savecodenow", "--swh-web-url", root_api_url,
				"origin", origin,
				"--visit-type", visit_type,
				],
				catch_exceptions=True,
				)
				# fmt: on

				assert result.output == (
				f"{SaveCodeNowCheck.TYPE} CRITICAL - {REPORT_MSG} {origin_info} took "
				f"0.00s and resulted in unsupported status: pending ; not created\n"
				f"\| 'total_time' = 0.00s\n"
				)
				assert result.exit_code == 2, f"Unexpected output: {result.output}"
				vsellierUnsubmitted Not Done Inline Actions random guy :) vsellier: random guy :)

docs/images/automatic-backport: Add detailed stepsAbandonedPublicActions