Differential D8948

svn: Fix propget operation when target is an URL
ClosedPublic
Actions

Authored by anlambert on Dec 9 2022, 10:58 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDSVN24d70804b72b: svn: Fix propget operation when target is an URL

Summary

subvertpy 0.11 has a buggy implementation of propget bindings when
target is an URL (https://github.com/jelmer/subvertpy/issues/35),
so as a workaround we implement propget for URL using non buggy
proplist bindings.

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Branch

svn-fix-propget

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 33203
Build 52056: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 52055: arc lint + arc unit

Event Timeline

anlambert created this revision.Dec 9 2022, 10:58 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 9 2022, 10:58 AM

anlambert added a child revision: D8949: svn: Remove use of costly checkout in SvnRepo.export_temporary.Dec 9 2022, 10:59 AM

Build is green

Patch application report for D8948 (id=32248)

Rebasing onto 91806d4471...

Current branch diff-target is up to date.

Changes applied before test

commit 24d70804b72b62c2531b68bc60db15a75bdb2bd5
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Dec 8 21:18:28 2022 +0100

    svn: Fix propget operation when target is an URL
    
    subvertpy 0.11 has a buggy implementation of propget bindings when
    target is an URL (https://github.com/jelmer/subvertpy/issues/35),
    so as a workaround we implement propget for URL using non buggy
    proplist bindings.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/368/ for more details.

Harbormaster completed remote builds in B33203: Diff 32248.Dec 9 2022, 11:02 AM

anlambert requested review of this revision.Dec 9 2022, 11:02 AM

ardumont accepted this revision.Dec 12 2022, 11:49 AM

This revision is now accepted and ready to land.Dec 12 2022, 11:49 AM

Closed by commit rDLDSVN24d70804b72b: svn: Fix propget operation when target is an URL (authored by anlambert). · Explain WhyDec 12 2022, 2:42 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDSVN24d70804b72b: svn: Fix propget operation when target is an URL.