task add: Ensure task type provided exist and raise otherwise
ClosedPublic
Actions

Authored by ardumont on Dec 7 2022, 12:48 PM.

Details

Reviewers

vlorentz
olasd

Group Reviewers

Reviewers

Commits

rDSCHe2878b5f65d8: task add: Ensure task type provided exist and raise otherwise

Summary

Test Plan

One new test added

Diff Detail

Repository

rDSCH Scheduling utilities

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 33138
Build 51943: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 51942: arc lint + arc unit

Event Timeline

ardumont created this revision.Dec 7 2022, 12:48 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 7 2022, 12:48 PM

Build is green

Patch application report for D8933 (id=32184)

Rebasing onto cd16fce903...

Current branch diff-target is up to date.

Changes applied before test

commit c221529768903a5be85c6874596d7e4cc13ba322
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Dec 7 12:38:58 2022 +0100

    task add: Make sure task type provided exist and raise otherwise
    
    Related to https://gitlab.softwareheritage.org/infra/sysadm-environment/-/issues/4674

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/576/ for more details.

Harbormaster completed remote builds in B33138: Diff 32184.Dec 7 2022, 12:52 PM

ardumont requested review of this revision.Dec 7 2022, 12:52 PM

vlorentz accepted this revision.Dec 7 2022, 12:55 PM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/scheduler/cli/task.py
272–274

This revision is now accepted and ready to land.Dec 7 2022, 12:55 PM

olasd accepted this revision.Dec 7 2022, 12:56 PM

ardumont retitled this revision from task add: Make sure task type provided exist and raise otherwise to task add: Ensure task type provided exist and raise otherwise.Dec 7 2022, 12:57 PM

Improve implementation according to suggestion
Rework commit and diff message

Build is green

Patch application report for D8933 (id=32187)

Rebasing onto cd16fce903...

Current branch diff-target is up to date.

Changes applied before test

commit e2878b5f65d8787e6ad6ca45c21f4333cf1679bb
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Dec 7 12:38:58 2022 +0100

    task add: Ensure task type provided exist and raise otherwise
    
    Related to https://gitlab.softwareheritage.org/infra/sysadm-environment/-/issues/4674

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/577/ for more details.

Harbormaster completed remote builds in B33141: Diff 32187.Dec 7 2022, 1:02 PM

Closed by commit rDSCHe2878b5f65d8: task add: Ensure task type provided exist and raise otherwise (authored by ardumont). · Explain WhyDec 7 2022, 1:43 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDSCHe2878b5f65d8: task add: Ensure task type provided exist and raise otherwise.