Paths

Table of Contentst

Differential D998

Make metadata translation warnings reference revisions/content ids instead of dumping the content itself.
ClosedPublic
Actions

Authored by vlorentz on Jan 24 2019, 4:34 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T1474: Mapping warnings should log the content/revision id, not the content itself

Commits

rDCIDX0af9b107bb82: Deduplicate mapping instantiation.
rDCIDX87b9fa2416e2: Make metadata translation warning reference revisions/content ids instead of…

Summary

Depends on D965.

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

log-ids

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 3731
Build 4867: tox-on-jenkins	Jenkins
Build 4866: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jan 24 2019, 4:34 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 24 2019, 4:34 PM

Harbormaster failed remote builds in B3691: Diff 3165!Jan 24 2019, 4:34 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/267/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/267/console

vlorentz added a task: T1474: Mapping warnings should log the content/revision id, not the content itself.Jan 24 2019, 4:35 PM

vlorentz retitled this revision from Make metadata translation warning reference revisions/content ids instead of dumping the content itself. to Make metadata translation warnings reference revisions/content ids instead of dumping the content itself..

ardumont accepted this revision.Jan 25 2019, 2:52 PM

ardumont added a subscriber: ardumont.

ardumont added inline comments.

swh/indexer/metadata.py
67	why does the call change here (reading more carefully the rest of the diff)? ... ok, it's not the call that changes, it's the initialization of the mapping class. That instantiation is now done at each `index` method call. As the init method allows to pass along a log_suffix now for the edge case failures, you can now log more information.
swh/indexer/tests/test_metadata.py
185	can't you extract that in the test setup (where it makes sense)? self.npm_mapping = MAPPINGS["NpmMapping"]()

This revision is now accepted and ready to land.Jan 25 2019, 2:52 PM

vlorentz marked an inline comment as done.Jan 25 2019, 2:54 PM

vlorentz added inline comments.

swh/indexer/tests/test_metadata.py
185	What's the difference?

ardumont added inline comments.Jan 25 2019, 3:09 PM

swh/indexer/tests/test_metadata.py
185	you stop the duplication all over the tests?

vlorentz marked an inline comment as done.Jan 25 2019, 3:40 PM

vlorentz added inline comments.

swh/indexer/tests/test_metadata.py
185	That's only a small expression

Deduplicate mapping instantiation.

Harbormaster failed remote builds in B3731: Diff 3200!Jan 25 2019, 3:48 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/275/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/275/console

rebase

Closed by commit rDCIDX87b9fa2416e2: Make metadata translation warning reference revisions/content ids instead of… (authored by vlorentz). · Explain WhyJan 29 2019, 10:16 AM

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B3776: Diff 3232!Jan 29 2019, 10:16 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/285/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/285/console

vlorentz mentioned this in T1474: Mapping warnings should log the content/revision id, not the content itself.Jan 29 2019, 10:57 AM

Revision Contents
Changeset List

Path

Size

swh/

indexer/

18 lines

metadata_dictionary.py

44 lines

tests/

test_metadata.py

64 lines

Diff 3200

swh/indexer/metadata.py

Loading...

swh/indexer/metadata_dictionary.py

Loading...

swh/indexer/tests/test_metadata.py

Loading...