Differential D8847

browse: Display branches names in snapshot releases view
ClosedPublic
Actions

Authored by anlambert on Nov 15 2022, 1:44 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T4686: Duplicated branch names are rendered by the webapp

Commits

rDWAPPS694802b2ac85: browse: Display branches names in snapshot releases view

Summary

Previously the snapshot releases view was only displaying the releases
names and not the branches names targeting those.

But it exist cases where multiple branches target the same release in
a snapshot so also display branches names in the releases table in order
to avoid confusion about duplicated releases.

Before:

After:

Related to T4686

Diff Detail

Repository

rDWAPPS Web applications

Branch

releases-view-display-branch-name

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32817
Build 51418: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 51417: arc lint + arc unit

Event Timeline

anlambert created this revision.Nov 15 2022, 1:44 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 15 2022, 1:44 PM

Build is green

Patch application report for D8847 (id=31882)

Rebasing onto 6531a36531...

Current branch diff-target is up to date.

Changes applied before test

commit 2bef1317a7863b7e0edfc8bf692d30552f577c4d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Nov 15 13:41:03 2022 +0100

    browse: Display branch name in snapshot releases view
    
    Previously the snapshot releases view was only displaying the releases
    names and not the branches names targeting those.
    
    But it exist cases where multiple branches target the same release in
    a snapshot so also display branches names in the releases table in order
    to avoid confusion about duplicated releases.
    
    Related to T4686

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2137/ for more details.

Harbormaster completed remote builds in B32817: Diff 31882.Nov 15 2022, 1:54 PM

anlambert requested review of this revision.Nov 15 2022, 1:54 PM

anlambert retitled this revision from browse: Display branch name in snapshot releases view to browse: Display branches names in snapshot releases view.Nov 15 2022, 1:57 PM

anlambert edited the summary of this revision. (Show Details)

Update commit message

ardumont accepted this revision.Nov 15 2022, 2:01 PM

This revision is now accepted and ready to land.Nov 15 2022, 2:01 PM

Build is green

Patch application report for D8847 (id=31884)

Rebasing onto 6531a36531...

Current branch diff-target is up to date.

Changes applied before test

commit 694802b2ac8514648b148008e340d441eadcb609
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Nov 15 13:41:03 2022 +0100

    browse: Display branches names in snapshot releases view
    
    Previously the snapshot releases view was only displaying the releases
    names and not the branches names targeting those.
    
    But it exist cases where multiple branches target the same release in
    a snapshot so also display branches names in the releases table in order
    to avoid confusion about duplicated releases.
    
    Related to T4686

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2138/ for more details.

Harbormaster completed remote builds in B32819: Diff 31884.Nov 15 2022, 2:09 PM

Closed by commit rDWAPPS694802b2ac85: browse: Display branches names in snapshot releases view (authored by anlambert). · Explain WhyNov 15 2022, 4:50 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS694802b2ac85: browse: Display branches names in snapshot releases view.

anlambert mentioned this in D8848: fedora: Update versions in packages dict provided as loader argument.Nov 15 2022, 5:11 PM

anlambert mentioned this in D8753: feat: Introduce RPM loader.Nov 15 2022, 5:34 PM